Skip to content

Commit

Permalink
fix: set launchShowDuration to 0 on new projects only (#2876)
Browse files Browse the repository at this point in the history
  • Loading branch information
jcesarmobile authored May 7, 2020
1 parent 6c2a099 commit 8de0414
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ public interface SplashListener {

public static final String CONFIG_KEY_PREFIX = "plugins.SplashScreen.";

public static final int DEFAULT_LAUNCH_SHOW_DURATION = 0;
public static final int DEFAULT_LAUNCH_SHOW_DURATION = 3000;
public static final int DEFAULT_FADE_IN_DURATION = 200;
public static final int DEFAULT_FADE_OUT_DURATION = 200;
public static final int DEFAULT_SHOW_DURATION = 3000;
Expand Down
7 changes: 6 additions & 1 deletion cli/src/common.ts
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,12 @@ export async function getOrCreateConfig(config: Config) {
appName: config.app.appName,
bundledWebRuntime: config.app.bundledWebRuntime,
npmClient: config.cli.npmClient,
webDir: basename(resolve(config.app.rootDir, config.app.webDir))
webDir: basename(resolve(config.app.rootDir, config.app.webDir)),
plugins: {
SplashScreen : {
launchShowDuration: 0
}
}
});

// Store our newly created or found external config as the default
Expand Down
2 changes: 1 addition & 1 deletion ios/Capacitor/Capacitor/Plugins/SplashScreen.swift
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ public class CAPSplashScreenPlugin: CAPPlugin {
var hideTask: Any?
var isVisible: Bool = false

let launchShowDuration = 0
let launchShowDuration = 3000
let launchAutoHide = true

let defaultFadeInDuration = 200
Expand Down

0 comments on commit 8de0414

Please sign in to comment.