fix(SplashScreen): show method not resolving if autoHide is false (#3144

)
ionic-team · Jun 29, 2020 · 28a0e42 · 28a0e42
1 parent 7b9ac92
commit 28a0e42
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/android/capacitor/src/main/java/com/getcapacitor/Splash.java b/android/capacitor/src/main/java/com/getcapacitor/Splash.java
@@ -243,6 +243,11 @@ public void run() {
               }
             }
           }, showDuration);
+        } else {
+          // If no autoHide, call complete
+          if (splashListener != null) {
+            splashListener.completed();
+          }
         }
       }
 

diff --git a/ios/Capacitor/Capacitor/Plugins/SplashScreen.swift b/ios/Capacitor/Capacitor/Plugins/SplashScreen.swift
@@ -183,6 +183,8 @@ public class CAPSplashScreenPlugin: CAPPlugin {
             self.hideSplash(fadeOutDuration: fadeOutDuration, isLaunchSplash: isLaunchSplash)
             completion()
           }
+        } else {
+            completion()
         }
       }
     }