feat(app): return promise in exitApp #777
Conversation
There was a problem hiding this comment.
Thanks for the PR
You also need to change CAP_PLUGIN_METHOD(exitApp, CAPPluginReturnNone); to CAP_PLUGIN_METHOD(exitApp, CAPPluginReturnPromise); in AppPlugin.m file.
We are not merging this yet as it's a breaking change and it's planned for when we start working in Capacitor 4 and version 2 of the plugins.
|
@jcesarmobile thanks for the report. Do we have a doc somewhere do learn oh to code and test ? |
|
we test on the capacitor-testapp, check its readme |
|
My issue is more about installing package and using git with Lerna, i see 0 changes do i need a specific VSCode plugin ? |
|
If you run npm install on the root, lerna runs npm install on all plugins, same if you run npm run build, lerna runs it for all. |
|
@jcesarmobile it seems from the doc i have to install Lerna in global right ? https://lerna.js.org/ |
|
Not sure, it’s on the devDependencies, so shouldn’t be needed globally, but if it’s not working then you can give it a try. |
|
@jcesarmobile yes with Global install that do way different install flow ! Now i'm able to run all commands ! |
|
@jcesarmobile i think that good in my side |
app/ios/Plugin/AppPlugin.m
Outdated
| @@ -9,5 +9,5 @@ | |||
| CAP_PLUGIN_METHOD(getLaunchUrl, CAPPluginReturnPromise); | |||
| CAP_PLUGIN_METHOD(getState, CAPPluginReturnPromise); | |||
| CAP_PLUGIN_METHOD(minimizeApp, CAPPluginReturnPromise); | |||
| CAP_PLUGIN_METHOD(removeAllListeners, CAPPluginReturnNone); | |||
| CAP_PLUGIN_METHOD(removeAllListeners, CAPPluginReturnPromise); | |||
There was a problem hiding this comment.
You have to change it in exitApp, not in removeAllListeners
| CAP_PLUGIN_METHOD(removeAllListeners, CAPPluginReturnPromise); | |
| CAP_PLUGIN_METHOD(removeAllListeners, CAPPluginReturnNone); |
|
Sorry @jcesarmobile i was sick yesterday :/ i updated |
|
@jcesarmobile good for you ? |
jcesarmobile
changed the title
document the type change in v2 of the plugin
closes #750