Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(camera): query IMAGE_CAPTURE intent required by SDK 30 #160

Merged
merged 2 commits into from
Dec 23, 2020

Conversation

jcesarmobile
Copy link
Member

When targeting SDK 30, users need to add the intents their app launch in their manifest the intents their app launches.

We can document it and make users do it, or we can put the queries on the plugin's AndroidManifest.xml for them as manifest merger will put it in the app's AndroidManifest.xml manifest too.

I went with the second approach because I think if users installed the plugin they will need this and they can miss it on the docs, so not having to manually add it is a better user experience.

@imhoffd imhoffd merged commit 6484991 into main Dec 23, 2020
@imhoffd imhoffd deleted the camera-sdk30-fix branch December 23, 2020 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants