-
Notifications
You must be signed in to change notification settings - Fork 614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Browser #16
Conversation
ikeith
commented
Aug 18, 2020
•
edited
Loading
edited
- Remove plugin from capacitor Chore: remove Browser plugin capacitor#3439
- JS wrapper and implementation
- iOS implementation
- Android implementation
- Test app integration Add Browser page capacitor-testapp#9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you copy in the following files from a plugin in main
? There have been changes:
.gitignore
.eslintignore
ESLint should be set up in this plugin.
Please remove the Podfile.lock and package-lock.json from git for this plugin, we're ignoring them now
Also missing the README.md and LICENSE files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few comments
browser/android/src/main/java/com/capacitorjs/plugins/browser/Browser.java
Outdated
Show resolved
Hide resolved
browser/android/src/main/java/com/capacitorjs/plugins/browser/BrowserPlugin.java
Outdated
Show resolved
Hide resolved
browser/android/src/main/java/com/capacitorjs/plugins/browser/BrowserPlugin.java
Outdated
Show resolved
Hide resolved
browser/android/src/main/java/com/capacitorjs/plugins/browser/Browser.java
Outdated
Show resolved
Hide resolved
…Browser.java Co-authored-by: jcesarmobile <jcesarmobile@gmail.com>
…BrowserPlugin.java Co-authored-by: jcesarmobile <jcesarmobile@gmail.com>
…BrowserPlugin.java Co-authored-by: jcesarmobile <jcesarmobile@gmail.com>
…Browser.java Co-authored-by: jcesarmobile <jcesarmobile@gmail.com>
Co-authored-by: jcesarmobile <jcesarmobile@gmail.com>
Co-authored-by: jcesarmobile <jcesarmobile@gmail.com>
Co-authored-by: jcesarmobile <jcesarmobile@gmail.com>
# Conflicts: # .gitignore # README.md # package.json