-
Notifications
You must be signed in to change notification settings - Fork 614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add SplashScreen plugin #149
Conversation
splash-screen/android/src/main/java/com/capacitorjs/plugins/splashscreen/SplashScreen.java
Outdated
Show resolved
Hide resolved
Couple of ideas
the |
As the idea of the implementation class is to make it easier to reuse the plugin by native code, it's easier to have a single object rather than a bunch of params. My code is based on Ian's approach on camera PR, which was approved by you and Dan, so if we want to use builders his PR should also be changed. I removed the show with no params because it was not being used and iOS didn't have an equivalent, but I can put it back if you want. But then iOS should also have something like that for consistency. |
I'm thinking from a reusability standpoint for this method:
You would call it:
or you could also do
if you just want defaults. If the first one is acceptable then that's fine. |
closes #133
closes #150