Update to testing version 3.9 - 3.11 #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
…DeespcoreSettings
…settings for running fast
niekdejonge
commented
Jun 25, 2024
| result = generate_test_results_ms2query(ms2library, local_test_spectra) | ||
| np.testing.assert_almost_equal(result[0], (0.5645, 0.003861003861003861, False)) | ||
| np.testing.assert_almost_equal(result[1], (0.409, 0.010610079575596816, False)) | ||
| results = generate_test_results_ms2query(ms2library, local_test_spectra) |
There was a problem hiding this comment.
@florian-huber We had many tests that check for specific outcomes of the models. This is not easily maintainable, here I have removed all these specific checks and replace with checks for correct types instead of values. Do you think this is the way to go? Or do you have any other suggestions?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made MS2Query MS2Deepscore 2.0 compatible.
Still to do: