Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace pandas append with concat #231

Merged
merged 2 commits into from
Nov 28, 2023

Conversation

mapio
Copy link
Contributor

@mapio mapio commented Nov 25, 2023

Presently the code uses a deprecated method. Moreover builds DataFrames incrementally, which is a waste of time and space.

This patch addresses both issues.

The ConcatVsAppend.pdf example gives a precise (and perhaps pedantic, sorry) explanation of the reason of this PR.

@niekdejonge
Copy link
Collaborator

Thanks!

@niekdejonge niekdejonge merged commit 6d8e1dc into iomega:main Nov 28, 2023
1 of 8 checks passed
@mapio mapio deleted the replace_pandas_append_with_concat branch November 28, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants