Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the example data in dummy_data #210

Closed
mapio opened this issue Nov 19, 2023 · 2 comments · Fixed by #215
Closed

Update the example data in dummy_data #210

mapio opened this issue Nov 19, 2023 · 2 comments · Fixed by #215

Comments

@mapio
Copy link
Contributor

mapio commented Nov 19, 2023

I'm using release 1.2.4 and following the README I run

ms2query --library library_folder --download --ionmode positive 
ms2query --spectra dummy_spectra.mgf --library library_folder --ionmode positive 

Where dummy_spectra.mgf is https://github.com/iomega/ms2query/blob/main/dummy_data/dummy_spectra.mgf.

Then I compared the output results/dummy_spectra.csv with expected_results_dummy_data.csv at https://github.com/iomega/ms2query/blob/main/dummy_data/expected_results_dummy_data.csv.

These two file have quite different contents, for instance, the list of headers is different (feature_id, retention_index and spectrum_ids appear only in one of the two files).

This can be confusing for a first time user. I think that updating the "dummy" test files will help to make users more confident that their installation and use is correct.

@mapio mapio changed the title Update the examples Update the example data in dummy_data Nov 19, 2023
@niekdejonge
Copy link
Collaborator

Good point, thanks for making an issue. I will check and update accordingly

@niekdejonge
Copy link
Collaborator

Fixed with #215

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants