Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converge Tracing/Profiling to Native Set of Hooks #729

Closed
trevnorris opened this issue Feb 5, 2015 · 8 comments
Closed

Converge Tracing/Profiling to Native Set of Hooks #729

trevnorris opened this issue Feb 5, 2015 · 8 comments
Assignees
Labels
discuss Issues opened for discussions and feedbacks. help wanted Issues that need assistance from volunteers or PRs that need help to proceed.

Comments

@trevnorris
Copy link
Contributor

We are looking for users to document pseudo-APIs that demonstrate what they are looking in a tracing or profiling API. Please submit or link to documents with examples of what information you'd like to gather from the process, and potential APIs of how to do so.

Tutorial on AsyncWrap

@trevnorris trevnorris added discuss Issues opened for discussions and feedbacks. enhancement help wanted Issues that need assistance from volunteers or PRs that need help to proceed. labels Feb 5, 2015
@trevnorris trevnorris self-assigned this Feb 5, 2015
@trevnorris
Copy link
Contributor Author

@thlorenz sent me this link to a header file in Chromium that has a tracing API: http://src.chromium.org/chrome/trunk/src/base/debug/trace_event.h

@Qard
Copy link
Member

Qard commented Feb 5, 2015

My idea is roughly this: https://gist.github.com/Qard/3cc472d85c9a7277dee8

When the flag for the static probes is off, the TRACE(...) and INSTRUMENT(...) macros would just do nothing, incurring no overhead. When turned on, it sets up a basic event emitter that third-party modules can listen for events from.

The ALL aspect of it is just a convenience thing. It might be better to require explicit handlers for each event type.

@trevnorris
Copy link
Contributor Author

Information from @natduca #671 (comment)

@GlenTiki
Copy link
Contributor

GlenTiki commented Feb 6, 2015

Some thoughts, I think everyone is kinda thinking along the same lines:

https://gist.github.com/thekemkid/c51ed25eb3a5a603cb7e

@sam-github
Copy link
Contributor

@Trott
Copy link
Member

Trott commented Mar 11, 2016

@trevnorris Is this still an issue to keep open? Maybe the discussion has moved elsewhere? Looks like no one's added anything for about a year.

@trevnorris
Copy link
Contributor Author

@Trott Think we can. Between finalizing a public AsyncWrap API and the v8 tracing API seems decisions have been made.

@Fishrock123
Copy link
Contributor

Closing as seems to be @trevnorris's reply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss Issues opened for discussions and feedbacks. help wanted Issues that need assistance from volunteers or PRs that need help to proceed.
Projects
None yet
Development

No branches or pull requests

7 participants