-
-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle invert_axes for all Element types #1919
Conversation
Looks good although I was hoping to see cruft removed with a replacement at the level of Happy to merge once the tests pass, ideally with a few new unit tests. |
This is not ready to review or merge. |
I know! Which is why I kept my comments general and checked you hadn't added the WIP tag (yet). |
d7c0451
to
d951392
Compare
d951392
to
eac70d7
Compare
Not really possible, a baseclass can't know how to properly invert the data for a particular Element. |
f747d70
to
2c39810
Compare
2c39810
to
5e85b93
Compare
Ready to merge. |
I'll merge though I do have one question.
Perhaps this could be made easy at the data API level? |
If it was just about |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
We never implemented
invert_axes
for all Element types. This code does that ensuring that any plot can now be adjoined.Fixes: