From 372a21c160bd4cc766d820b9acbc0b0789bae390 Mon Sep 17 00:00:00 2001 From: Alexander Date: Wed, 15 Jun 2022 12:33:38 +0300 Subject: [PATCH 1/2] Remove ad_impression from reserved events --- packages/analytics/lib/index.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/packages/analytics/lib/index.js b/packages/analytics/lib/index.js index 7d22a90690..60256cdd85 100644 --- a/packages/analytics/lib/index.js +++ b/packages/analytics/lib/index.js @@ -39,8 +39,9 @@ import * as structs from './structs'; const ReservedEventNames = [ 'ad_activeview', 'ad_click', - 'ad_exposure', - 'ad_impression', + 'ad_exposure', + // manual tracking on this reserved word is allowed https://github.com/invertase/react-native-firebase/issues/6307 + //'ad_impression', 'ad_query', 'ad_reward', 'adunit_exposure', From 216fe4017e474d2501f3bdc465f30276f4a53ca3 Mon Sep 17 00:00:00 2001 From: Alexander Date: Wed, 15 Jun 2022 12:47:30 +0300 Subject: [PATCH 2/2] Dummy commit to make PR's title a commit message --- packages/analytics/lib/index.js | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/analytics/lib/index.js b/packages/analytics/lib/index.js index 60256cdd85..fb196be427 100644 --- a/packages/analytics/lib/index.js +++ b/packages/analytics/lib/index.js @@ -40,6 +40,7 @@ const ReservedEventNames = [ 'ad_activeview', 'ad_click', 'ad_exposure', + // manual tracking on this reserved word is allowed https://github.com/invertase/react-native-firebase/issues/6307 //'ad_impression', 'ad_query',