Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(messaging, ios): Support Ephemeral authorization state #6478

Merged
merged 3 commits into from
Aug 26, 2022

Conversation

navro
Copy link
Contributor

@navro navro commented Aug 18, 2022

Description

Adds support for the authorization status UNAuthorizationStatusEphemeral that was introduced with iOS 14. This status can be returned for App Clips, and means that notifications are allowed for a limited amount of time. See https://developer.apple.com/documentation/app_clips/enabling_notifications_in_app_clips

Related issues

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan


Think react-native-firebase is great? Please consider supporting the project with any of the below:

@CLAassistant
Copy link

CLAassistant commented Aug 18, 2022

CLA assistant check
All committers have signed the CLA.

@vercel
Copy link

vercel bot commented Aug 18, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-native-firebase ✅ Ready (Inspect) Visit Preview Aug 26, 2022 at 2:51PM (UTC)
1 Ignored Deployment
Name Status Preview Updated
react-native-firebase-next ⬜️ Ignored (Inspect) Aug 26, 2022 at 2:51PM (UTC)

mikehardy
mikehardy previously approved these changes Aug 26, 2022
Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is basically perfect - and I appreciate your patience, I'm just getting caught up over here after summer travel. I made a nitpick/tiny suggestion that I should be able to apply myself, then we can get this merged

packages/messaging/ios/RNFBMessaging/RNFBMessagingModule.m Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Aug 26, 2022

Codecov Report

Merging #6478 (d2225a6) into main (dc74643) will decrease coverage by 29.08%.
The diff coverage is n/a.

❗ Current head d2225a6 differs from pull request most recent head 2d89f5b. Consider uploading reports for the commit 2d89f5b to get more accurate results

@@              Coverage Diff              @@
##               main    #6478       +/-   ##
=============================================
- Coverage     54.90%   25.83%   -29.07%     
=============================================
  Files           208       97      -111     
  Lines         10358     4291     -6067     
  Branches       1645     1048      -597     
=============================================
- Hits           5686     1108     -4578     
+ Misses         4371     2583     -1788     
- Partials        301      600      +299     

@mikehardy
Copy link
Collaborator

I just tacked on a commit with diff from yarn lint:ios:fix run on local pull of PR, should go green now I think 🤞

@mikehardy
Copy link
Collaborator

There is no reason the android emulator should fail, and after a couple retries it seems to be fully busted at the moment, something I just fixed in another project. Going to defer that here but since it didn't touch any android stuff, will merge

@mikehardy mikehardy merged commit 795b684 into invertase:main Aug 26, 2022
@mikehardy mikehardy removed the Workflow: Pending Merge Waiting on CI or similar label Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants