fix(analytics, ios): handle RNFirebaseAnalyticsWithoutAdIdSupport == false Podfile case correctly

[OskarJuszczyk]

Description

Right know it looks only if it is defined and not if it set as true, same error as in older appsflyer-react-native-plugin xD

Release Summary

Fix RNFirebaseAnalyticsWithoutAdIdSupport flag in Podfile

Checklist

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • Yes
• My change supports the following platforms;
  • Android
  • iOS
• My change includes tests;
  • e2e tests added or updated in packages/\*\*/e2e
  • jest tests added or updated in packages/\*\*/__tests__
• I have updated TypeScript types that are affected by my change.
• This is a breaking change; (Hard to decide I would say yes because it will change someones dependencies after upgrade)
  • Yes
  • No

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

react-native-firebase – ./

🔍 Inspect: https://vercel.com/invertase/react-native-firebase/C3eyXzECQuc57RMHqDWFfEpZ6qi1
✅ Preview: https://react-native-firebase-git-fork-oskarjuszczyk-patch-1-invertase.vercel.app

react-native-firebase-next – ./website_modular

🔍 Inspect: https://vercel.com/invertase/react-native-firebase-next/7iuq1CSuJLnVunYE7oRREv4zwyVC
✅ Preview: Canceled

[Deployment for 8ac2cf0 canceled]

[CLAassistant]

All committers have signed the CLA.

[mikehardy]

Oh my, that looks like a 🤦 error / incorrect assumption.
Of course most that define this will only define it if they want to set it to true, but, also (of course) you can define it false if you like.
Thanks for the catch + PR!

[codecov]

Codecov Report

Merging #6078 (d66c781) into main (d9cf9c3) will increase coverage by 19.20%.
The diff coverage is n/a.

❗ Current head d66c781 differs from pull request most recent head 8ac2cf0. Consider uploading reports for the commit 8ac2cf0 to get more accurate results

@@              Coverage Diff              @@
##               main    #6078       +/-   ##
=============================================
+ Coverage     52.92%   72.11%   +19.20%     
=============================================
  Files           208      109       -99     
  Lines         10220     4618     -5602     
  Branches       1626     1040      -586     
=============================================
- Hits           5408     3330     -2078     
+ Misses         4558     1210     -3348     
+ Partials        254       78      -176     

[mikehardy]

The PR Title failure is okay, it's more of a warning for maintainers on merge since github handles single-commits in a surprising way. If the rest are green, we're ✔️

[mikehardy]

Sorry for the delay publishing this one! Oversight on my part I did not realize we had this fix unpublished. I just kicked off the release process now