feat(firestore): serverTimestampBehavior #5556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). react-native-firebase – ./🔍 Inspect: https://vercel.com/invertase/react-native-firebase/68cNq9VtVNQpLnuvELznyR6bKKkF react-native-firebase-next – ./website_modular🔍 Inspect: https://vercel.com/invertase/react-native-firebase-next/BxWgJy8iX1f8buxH33fs9xtx4U35 |
8 tasks
|
Previous PR had CLA signed on same commits carried in to here, this is just waiting on CI |
JanErikFoss
approved these changes
Jul 30, 2021
|
Yes! All green (again), this time even with the vercel thing that fomented my awful branch clobber (sorry again). |
androidIsForVivek
pushed a commit
to androidIsForVivek/react-native-firebase
that referenced
this pull request
Aug 9, 2021
* feat: serverTimestampBehavior
* Add test for firestore().settings({ serverTimestampBehavior })
* Add e2e tests
Co-authored-by: Jan Erik Foss <solafosstek@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is 100% from @JanErikFoss - just carried his commits into this PR after clobbering #5514
Implements serverTimestampBehavior as a firestore setting.
It's currently impossible to implement SnapshotOptions as they work in the javascript sdk, this is the next best option in my opinion.
Related issues
#5514
Release Summary
Squash-merge - PR title is conventional
Checklist
AndroidiOSe2etests added or updated inpackages/\*\*/e2ejesttests added or updated inpackages/\*\*/__tests__Test Plan
Think
react-native-firebaseis great? Please consider supporting the project with any of the below:React Native FirebaseandInvertaseon Twitter