[🐛] "auth"/linkWithCredential, does not return credential-already-in-use #4911
Labels
platform: android
plugin: authentication
Firebase Authentication
type: bug
New bug report
Type: Stale
Issue has become stale - automatically added by Stale bot
Workflow: Needs Review
Pending feedback or review from a maintainer.
Comments
cqwcent
added
help: needs-triage
|
I have the same issue on Android with |
|
@devtud have you tried reverting the firebase-android-sdk version back to the one that was in use with the last version of react-native-firebase that worked for you? The gradle build logs will tell you which firebase-android-sdk is being used and rnfirebase.io has instructions on how to override for testing https://rnfirebase.io/#android |
|
@mikehardy I have overwritten bom 26.5.0 with 26.0.0 and it seems the |
|
Interesting. Then it is one of these two releases: https://firebase.google.com/support/release-notes/android#auth_v20-0-1 (firebase-android-sdk 26.1.0) @devtud can you confirm which one breaks? If we know for sure 26.0.0 works and 26.1.0 breaks or that 26.2.0 still works but 26.3.0 breaks then we can really limit our search area for the regression down I really appreciate the testing, thank you |
|
@mikehardy , 26.1.0 breaks. |
mikehardy
added
the
Workflow: Needs Review
|
Unfortunately if I understand correctly firebase-android-sdk has not open sourced the auth module, but they do still track their issues on github (for auth as well) https://github.com/firebase/firebase-android-sdk/issues/new?assignees=&labels=&template=bug.md They typically want a reproduction but they offer quickstarts to make it relatively painless https://github.com/firebase/quickstart-android/tree/master/auth - I suppose the hard part will be integrating the facebook example but they have a pretty good guide for native as well https://developers.facebook.com/docs/facebook-login/android While recognizing that's a pain, if the only thing changed here (in react-native-firebase) was using underlying android SDK 26.0.0 vs 26.1.0, it's got to be an upstream issue and it must be pursued there |
mikehardy
added
blocked: firebase-support
|
Hi @mikehardy I am facing this same issue on linkWithCredentials while trying to link the PhoneNo. on Android Devices. It works fine on IOS devices. I did debug and found on the Android side on the error is caught logged on the console however its not returned and instead the user linked with phone no. is returned.
the section of code giving the issue. |
|
@GautamKrishnan I don't understand how that moves the issue forward in the context of my previous comment. Can you explain? Or are we still waiting for a native reproduction and information from firebase-android-sdk support? |
|
I'm having the same issue. |
|
@modmido how did it go when you did a native reproduction and submitted it to firebase-android-sdk issue tracker? |
|
Same here. Created an issue. If anyone one would be able to create a reproducable demo - he would be a hero. Any thought what could be done right now to prevent data loss from anonymous user while linking accounts? |
|
@RohovDmytro Hi, I commented this portion in ReactNativeFirebaseAuthModule.java and returned the promiseRejectAuthException(promise, exception);
|
|
Solution from @GautamKrishnan seems to work fine for me. Trying to link with an existing account throws an error, linking with a new (email) account works fine. Patch in case anyone needs it (yes, unclean indentations ^^): |
|
We've never done this before but I want to help - if there was some way to constrain this workaround in the code to only the affected firebase-android-sdks that are affected 26.1.0 up through but maybe not including(?) 27.0.0 maybe we could include the version check then the workaround? I'm not sure if firebase-android-sdk's auth module makes it's version available dynamically or not to make something like that work |
|
Hello 👋, to help manage issues we automatically close stale issues.
|
stale
bot
added
the
Type: Stale
|
I am having the same issue, we have anonymouse users + phone auth and I am trying to On the other hand Android version attempts to do all of this automatically, which @GautamKrishnan tried to avoid by just replacing it with In my case this was only half working, because now I was getting a "auth/credential-already-in-use" error as expected, but still no updated credentials that I can use to attempt a |
stale
bot
removed
the
Type: Stale
|
I think this was fixed with #5694 - the original PR that added the attempt in android to upgrade anonymous users was later disavowed as no longer working by the author so removing it seems non-breaking (it was already broken?) and now the platforms should be equivalent. v12.7.5 release here has it |
|
@mikehardy FYI the revert still doesn't push the updated credentials to the JS side. In order to properly fix this, you'll have to add the patch based on the work of @Shaninnik):
import com.google.firebase.auth.FirebaseAuthInvalidCredentialsException;
private HashMap<String, AuthCredential> credentials = new HashMap<>();
private AuthCredential getCredentialForProvider(
String provider, String authToken, String authSecret) {
if (credentials.containsKey(authToken) && credentials.get(authToken) != null) {
return credentials.get(authToken);
} else {
switch (provider) {
case "facebook.com":
return FacebookAuthProvider.getCredential(authToken);
case "google.com":
return GoogleAuthProvider.getCredential(authToken, authSecret);
case "twitter.com":
return TwitterAuthProvider.getCredential(authToken, authSecret);
case "github.com":
return GithubAuthProvider.getCredential(authToken);
case "apple.com":
return OAuthProvider.newCredentialBuilder(provider)
.setIdTokenWithRawNonce(authToken, authSecret)
.build();
case "oauth":
return OAuthProvider.getCredential(provider, authToken, authSecret);
case "phone":
return getPhoneAuthCredential(authToken, authSecret);
case "password":
// authToken = email
// authSecret = password
return EmailAuthProvider.getCredential(authToken, authSecret);
case "emailLink":
// authToken = email
// authSecret = link
return EmailAuthProvider.getCredentialWithLink(authToken, authSecret);
default:
return null;
}
}
}
/**
* promiseRejectLinkAuthException
*
* @param promise
* @param exception
* @param authCredential
*/
private void promiseRejectLinkAuthException(Promise promise, Exception exception, AuthCredential authCredential) {
WritableMap error = getJSError(exception);
String authHashCode = String.valueOf(authCredential.hashCode());
WritableMap authCredentialsMap = Arguments.createMap();
authCredentialsMap.putString("providerId", authCredential.getProvider());
authCredentialsMap.putString("token", authHashCode);
authCredentialsMap.putString("secret", null);
// Temporarily store the non-serializable credential for later
credentials.put(authHashCode, authCredential);
WritableMap userInfoMap = Arguments.createMap();
userInfoMap.putString("code", error.getString("code"));
userInfoMap.putString("message", error.getString("message"));
userInfoMap.putMap("authCredential", authCredentialsMap);
promise.reject(error.getString("code"), error.getString("message"), userInfoMap);
}@ReactMethod
private void linkWithCredential(
String appName, String provider, String authToken, String authSecret, final Promise promise) {
FirebaseApp firebaseApp = FirebaseApp.getInstance(appName);
FirebaseAuth firebaseAuth = FirebaseAuth.getInstance(firebaseApp);
AuthCredential credential = getCredentialForProvider(provider, authToken, authSecret);
if (credential == null) {
rejectPromiseWithCodeAndMessage(
promise,
"invalid-credential",
"The supplied auth credential is malformed, has expired or is not currently supported.");
} else {
FirebaseUser user = firebaseAuth.getCurrentUser();
Log.d(TAG, "link");
if (user != null) {
user.linkWithCredential(credential)
.addOnCompleteListener(
getExecutor(),
task -> {
if (task.isSuccessful()) {
Log.d(TAG, "link:onComplete:success");
promiseWithAuthResult(task.getResult(), promise);
} else {
Exception exception = task.getException();
if (exception instanceof FirebaseAuthUserCollisionException) {
FirebaseAuthUserCollisionException authUserCollisionException = (FirebaseAuthUserCollisionException) exception;
AuthCredential updatedCredential = authUserCollisionException.getUpdatedCredential();
Log.e(TAG, "link:onComplete:collisionFailure", exception);
promiseRejectLinkAuthException(promise, exception, updatedCredential);
} else {
Log.e(TAG, "link:onComplete:failure", exception);
promiseRejectAuthException(promise, exception);
}
}
});
} else {
promiseNoUser(promise, true);
}
}
}From the JS-side, you can now do the following: try {
// try linking credential
await auth().currentUser!.linkWithCredential(credential);
await auth().currentUser!.reload();
// Handle success
} catch (err) {
const error = err as FirebaseAuthTypes.NativeFirebaseAuthError;
// If authCredentials are available, we can log in on the
// account that we attempted to link with
if (error.userInfo.authCredential) {
await auth().signInWithCredential(error.userInfo.authCredential);
await auth().currentUser!.reload();
// Handle success, but now logged into the linked account
}
// Handle errorI got a got diff, but its mired with style changes, so hope you're able to follow. |
|
Is there a way for you to use patch-package or similar? the text of the new is nowhere near as powerful as a diff I can examine + apply :-), one goes in the "oh no, needs triage" pile, one goes in the "review and likely merge" pile, and review+merge pile gets processed satisfyingly quickly, triage pile is slooow |
|
@mikehardy as said, my patch-package will get really messy due to stying changes. This approach now mirrors iOS perfectly. The same JS code can be used on both platforms to handle account colissions. Here it is: |
|
Quite alright - I can still apply it then use tools to ignore spacing etc :-), thanks for posting this |
mikehardy
added
Workflow: Needs Review
|
@mikehardy There is also my patch that I've posted earlier here, been running it ever since in production with 0 issues. The one that @kristfal posted appears to be more complete, unfortunately I can't review right now |
|
Hello 👋, to help manage issues we automatically close stale issues.
|
stale
bot
added
the
Type: Stale
mikehardy
removed
the
Type: Stale
|
Hello 👋, to help manage issues we automatically close stale issues. This issue has been automatically marked as stale because it has not had activity for quite some time.Has this issue been fixed, or does it still require attention?
Thank you for your contributions. |
github-actions
bot
added
the
Type: Stale
|
@mikehardy I have just checked the source code for the latest version of auth and I think it is still an issue. (cant check because I cant use and |
github-actions
bot
removed
the
Type: Stale
|
Hello 👋, to help manage issues we automatically close stale issues. This issue has been automatically marked as stale because it has not had activity for quite some time.Has this issue been fixed, or does it still require attention?
Thank you for your contributions. |
github-actions
bot
added
the
Type: Stale
|
is this resolved? I'm still not getting the credentials on the error object for Android? |
|
This issue is still not resolved. You still can't upgrade anonymous users using phone auth on Android. Still same issue: iOS is passing |
|
This is still an issue in April 2024. Shouldn't this just be a simple merge of the above patch @mikehardy ? |
|
@joaqo reasonable PRs are merged if you would like to propose one - I haven't looked at this closely in a while but I try to merge PRs as a high priority with any time I have if you propose one |
|
Tested @Shaninnik's patch and it works perfectly. Created this PR so other people can have it in the future as well. Added credit to @Shaninnik in the commit message, thanks for the great patch! @mikehardy I think its ready to merge. |
|
Sorry this closed stale, thanks very much to @joaqo for carrying through the excellent detective + fixing work from @Shaninnik @kristfal and all the others collaborating here. This should now close for real when #7793 merges and releases |
|
@joaqo thank you for your time creating this PR! |
|
Awesome, thank you for the quick merge! 👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Issue
Application with email/password, and Facebook login.
On Android, create email/password account, name it ABC. And link it with Facebook account. Success. Expected.
On Android, create another email/password account, name it XYZ. And try to link it with the same Facebook account. Expecting an error "credential-already-in-use", but instead, "auth" proceed login process and retrieved ABC's information.
Wipe out ABC and XYZ info on firebase console.
On IOS, create email/password account, name it ABC. And link it with Facebook account. Success. Expected.
On IOS, create another email/password account, name it XYZ. And try to link it with the same Facebook account. Got "credential-already-in-use", as expected.
GIF, Android, not as expected.
Screen recording, IOS, expected.
mac_link_social_expected.mov
Code used to link:
Project Files
Javascript
Click To Expand
package.json:iOS
Click To Expand
ios/Podfile:AppDelegate.m:Android
Click To Expand
Have you converted to AndroidX?
android/gradle.settingsjetifier=truefor Android compatibility?jetifierfor react-native compatibility?android/build.gradle:android/app/build.gradle:android/settings.gradle:MainApplication.java:AndroidManifest.xml:Environment
Click To Expand
react-native infooutput:Android test was performed on both Mac and Windows.
react-native-firebaseversion you're using that has this issue:Firebasemodule(s) you're using that has the issue:TypeScript?React Native FirebaseandInvertaseon Twitter for updates on the library.The text was updated successfully, but these errors were encountered: