-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(crashlytics ios): put input files when pod install. #4520
feat(crashlytics ios): put input files when pod install. #4520
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/invertase/react-native-firebase/7iz5xrdjk |
Codecov Report
@@ Coverage Diff @@
## master #4520 +/- ##
=======================================
Coverage 41.92% 41.92%
=======================================
Files 35 35
Lines 1119 1119
Branches 278 278
=======================================
Hits 469 469
Misses 489 489
Partials 161 161 |
The fork workflow is just fine - I'll look this over, thanks for taking the time to make a PR! 👏 |
Hey there - thanks again for the PR A quick question: is this backwards-compatible? If we merge it will it change the behavior for existing users in any way? Also, the CLA must be signed before we can merge (just click the details link next to the CLA check in the list of checks that run and it will take you through it) |
Hi, thanks for your comments!
I agreed with CLA!
Before: When Pod install, Does not include Input Files. After: When Pod install, Automatically include Input Files. I made it exactly as described in the Firebase documentation. I can add it manually on Xcode, but under the current situation, xcodeproj is rewritten by Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thank you!
Description
I commit to this repository for the first time.
I'm sorry if there is a wrong way.
Put the Build Phase setting of iOS when pod install.
https://firebase.google.com/docs/crashlytics/get-started?hl=ja#initialize-crashlytics
I want to add Input Files.
${DWARF_DSYM_FOLDER_PATH}/${DWARF_DSYM_FILE_NAME}/Contents/Resources/DWARF/${TARGET_NAME}
$(SRCROOT)/$(BUILT_PRODUCTS_DIR)/$(INFOPLIST_PATH)
Related issues
Discussion #4519
Release Summary
Checklist
Android
iOS
e2e
tests added or updated inpackages/\*\*/e2e
jest
tests added or updated inpackages/\*\*/__tests__
Test Plan
Think
react-native-firebase
is great? Please consider supporting the project with any of the below:React Native Firebase
andInvertase
on Twitter