fix(crashlytics): hard crash using SIGSEGV. #4426
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current exception won't be reported to crashlytics in both debug and release builds for now. Though I guess it was working at that time. (same as #4421)
I found a working solution from Sentry, I've also tested it, and I checked it is also working for crashlytics.
https://github.com/getsentry/sentry-cocoa/blob/7e2fff30271712bbf68747af1b198dfadf48e1a3/Sources/Sentry/SentryClient.m#L180-L183
The important thing about this approach is that there is no room for runtime to catch
If this PR is decided as okay, I can abandon #4421.
Related issues
#4374
#4126
#4421
Release Summary
Checklist
Android
iOS
e2e
tests added or updated inpackages/\*\*/e2e
jest
tests added or updated inpackages/\*\*/__tests__
Test Plan
Think
react-native-firebase
is great? Please consider supporting the project with any of the below:React Native Firebase
andInvertase
on Twitter