Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(crashlytics): hard crash using SIGSEGV. #4426

Merged
merged 1 commit into from
Oct 21, 2020
Merged

fix(crashlytics): hard crash using SIGSEGV. #4426

merged 1 commit into from
Oct 21, 2020

Conversation

RyogaK
Copy link
Contributor

@RyogaK RyogaK commented Oct 21, 2020

Description

The current exception won't be reported to crashlytics in both debug and release builds for now. Though I guess it was working at that time. (same as #4421)

I found a working solution from Sentry, I've also tested it, and I checked it is also working for crashlytics.
https://github.com/getsentry/sentry-cocoa/blob/7e2fff30271712bbf68747af1b198dfadf48e1a3/Sources/Sentry/SentryClient.m#L180-L183
The important thing about this approach is that there is no room for runtime to catch

If this PR is decided as okay, I can abandon #4421.

Related issues

#4374
#4126
#4421

Release Summary

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan


Think react-native-firebase is great? Please consider supporting the project with any of the below:

@vercel
Copy link

vercel bot commented Oct 21, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/invertase/react-native-firebase/kw7eog78o
✅ Preview: https://react-native-firebase-git-patch-2.invertase.vercel.app

@codecov
Copy link

codecov bot commented Oct 21, 2020

Codecov Report

Merging #4426 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4426   +/-   ##
=======================================
  Coverage   41.92%   41.92%           
=======================================
  Files          35       35           
  Lines        1119     1119           
  Branches      278      278           
=======================================
  Hits          469      469           
  Misses        489      489           
  Partials      161      161           

@mikehardy
Copy link
Collaborator

Oh now this is exciting 😄 💪 - nearly start of day here and I had the other queued for testing. I'll give this one a shot as if avoids the redbox so we get debug crashes too you will have solved the complete thing. Thanks again for picking this up @RyogaK - this is one of our most frustrating existing issues in the repo I believe, if not the most frustrating one

@mikehardy mikehardy added Workflow: Needs Review Pending feedback or review from a maintainer. Workflow: Pending Merge Waiting on CI or similar labels Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants