Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use the new recommended way to manually crash #4111

Merged
merged 1 commit into from
Aug 20, 2020

Conversation

mars-lan
Copy link
Contributor

Description

assert(no) was the original method recommended by Firebase but it turns out that it doesn't actually work (see firebase/firebase-ios-sdk#6028 for more detail). They've subsequently updated the official doc:
https://firebase.google.com/docs/crashlytics/test-implementation?platform=ios

Related issues

While no fixing #4026 completely, it's one step closer.

Release Summary

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan


Think react-native-firebase is great? Please consider supporting the project with any of the below:

@mikehardy
Copy link
Collaborator

This is fantastic, thank you - seriously. Lots of users pulling hair out on this issue and this is one step closer yes

@mikehardy
Copy link
Collaborator

e2e errors are unrelated, I'm investigating them separately but will merge this shortly either way and kick out a release on this one

@mikehardy mikehardy merged commit 6b136c3 into invertase:master Aug 20, 2020
@mars-lan
Copy link
Contributor Author

This is fantastic, thank you - seriously. Lots of users pulling hair out on this issue and this is one step closer yes

Here's another potential pitfall: #3902

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants