Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support critical alert permissions #3852

Merged
merged 2 commits into from
Jun 30, 2020
Merged

feat: support critical alert permissions #3852

merged 2 commits into from
Jun 30, 2020

Conversation

Zohaad97
Copy link
Contributor

@Zohaad97 Zohaad97 commented Jun 28, 2020 •
edited
Loading

Description

The current version has no support to ask the permission for critical alerts in ios. So I added criticalAlert boolean that is false by default and also added in IOSPermissions.

Related issues

Release Summary

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

@Zohaad97
Copy link
Contributor Author

@mikehardy @Salakar I made a pull request with the same commit two days ago that was approved by you. Because of some CLA issues I closed the earlier pull request and created a new one now. Kindly take a look.

mikehardy
mikehardy approved these changes Jun 28, 2020
View reviewed changes
Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still looks good to me @Zohaad97 - @Salakar CLA issues resolved...

@Salakar Salakar changed the title Critical alert permissions enabled. feat: support critical alert permissions Jun 30, 2020
@Salakar Salakar merged commit c8f7c31 into invertase:master Jun 30, 2020
@Salakar
Copy link
Member

Salakar commented Jun 30, 2020

Thanks @Zohaad97 - this has been merged and will appear in a release once CI finishes.

hmhm2292 pushed a commit to hmhm2292/react-native-firebase that referenced this pull request Jul 13, 2021
@Zohaad97
feat: support critical alert permissions (invertase#3852)
6c01505
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikehardy mikehardy mikehardy approved these changes

@Salakar Salakar Salakar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Zohaad97 @Salakar @mikehardy