Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(firestore): support limitToLast query filter #3702

Merged
merged 7 commits into from
Jun 22, 2020

Conversation

russellwheatley
Copy link
Member

  • set limit to undefined when limitToLast is set after limit and vice-versa.
  • validate get & snapshot for presence of order if limitToLast is set. It is required for both.
  • updated mocha tests for Firestore as nested tests weren't included.

@Salakar Salakar marked this pull request as ready for review May 28, 2020 21:44
@Salakar Salakar changed the title feat(firestore): added limitToLast API feat(firestore): support limitToLast query filter May 28, 2020
@Salakar
Copy link
Contributor

Salakar commented May 29, 2020

Native crash happening on Android Firestore - needs investigating first, the tests weren't all enabled originally - you had a .only

@Salakar Salakar merged commit dc7f921 into master Jun 22, 2020
@Salakar Salakar deleted the @russell/firestore-limitToLast branch June 22, 2020 11:14
androidIsForVivek pushed a commit to androidIsForVivek/react-native-firebase that referenced this pull request Aug 9, 2021
Co-authored-by: Mike Diarmid <mike.diarmid@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants