-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[!] NPM package '@react-native-firebase/analytics' depends on '@react-native-firebase/app' v6.7.1 but found v7.0.0, this might cause build issues or runtime crashes. #3642
Comments
What are the full steps that you did to receive this? v7.0.0 was just published and I'm guessing there is a partial update in your project instead of a full one? Are you certain you have updated all of your packages to v7.0.0? |
Interesting - I also notice on yarn install that the peer dependencies give similar warnings that they are expecting 6.7.1 but getting 7.0.0 - and I see your error as well when I run https://github.com/mikehardy/rnfbdemo/blob/master/make-demo-v6.sh on macOS (I had tested it on linux with @Salakar right after he pushed v7.0.0 out and it seemed fine - I should have checked macOS as well obviously) While these are warnings that definitely need fixing, they are exactly the sort of thing you'd expect as react-native-firebase goes from lockstep versioning in v6 to independent versioning in v7 I'm not saying I guarantee everything will work but these were just published and they passed all the CI tests plus my demo script does actually run as well, should be okay to develop against for now while this is sorted |
In packages.json 6.7.1 is defined as a peer dependency, but in the pod file for every package it checks that the peer dependency version is the same as the version we install https://github.com/invertase/react-native-firebase/blob/master/packages/analytics/package.json#L25 So this can probably be fixed by setting the peer dependency to 7.0.0, but I guess that will require that all packages know the next app version when releasing, or that app is always released first and then all sub packages. |
Urgh lerna should have bumped these as part of the release, turns out lerna doesn't bump peerDependencies: lerna/lerna#1575 😭 Gonna have to push a manual fix for this, will do shortly. On the plus side, the warnings are all working correctly 😀 |
7.0.1 works. Thank you
|
In my case, I've resolved the problem by doing this:
|
|
...or just |
Version
@react-native-firebase 7.0.0
Example
The text was updated successfully, but these errors were encountered: