Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔥 Clear getInitialLink after first call #3027

Closed
4 of 10 tasks
rtman opened this issue Dec 19, 2019 · 9 comments · Fixed by #4735
Closed
4 of 10 tasks

🔥 Clear getInitialLink after first call #3027

rtman opened this issue Dec 19, 2019 · 9 comments · Fixed by #4735
Labels
Type: Stale Issue has become stale - automatically added by Stale bot

Comments

@rtman
Copy link

rtman commented Dec 19, 2019

Issue

Just making an issue for this as it was part of another issue and was getting lost.

getInitialLink will return the link until the app is killed. There are certain scenarios where you need to process the link on the first time it shows up only, it would be great if it returned null after the first call (or cleared the link in some manner). @mikehardy was talking about dequeing in this comment seems like it would work great here.

Project Files

Javascript

Click To Expand

package.json:

firebase.json for react-native-firebase v6:

iOS

Click To Expand

ios/Podfile:

  • I'm not using Pods
  • I'm using Pods and my Podfile looks like:

AppDelegate.m:


Android

Click To Expand

Have you converted to AndroidX?

  • my application is an AndroidX application?
  • I am using android/gradle.settings jetifier=true for Android compatibility?
  • I am using the NPM package jetifier for react-native compatibility?

android/build.gradle:

android/app/build.gradle:

android/settings.gradle:

MainApplication.java:

AndroidManifest.xml:


Environment

  • Platform that you're experiencing the issue on:
    • iOS
    • Android
    • iOS but have not tested behavior on Android
    • Android but have not tested behavior on iOS
    • Both
  • react-native-firebase version you're using that has this issue:
    • e.g. 5.6.0
  • Firebase module(s) you're using that has the issue:
    • DynamicLinks
  • Are you using TypeScript?
    • Y 3.7.3


Think react-native-firebase is great? Please consider supporting all of the project maintainers and contributors by donating via our Open Collective where all contributors can submit expenses. [Learn More]

@rtman rtman changed the title (:fire:) Clear getInitialLink after first call 🔥 Clear getInitialLink after first call Dec 19, 2019
@stale
Copy link

stale bot commented Jan 17, 2020

Hello 👋, to help manage issues we automatically close stale issues.
This issue has been automatically marked as stale because it has not had activity for quite some time. Has this issue been fixed, or does it still require the community's attention?

This issue will be closed in 15 days if no further activity occurs.
Thank you for your contributions.

@stale stale bot added the Type: Stale Issue has become stale - automatically added by Stale bot label Jan 17, 2020
@ovy9086
Copy link

ovy9086 commented Jan 21, 2020

shouldn't really be stale bot . this is happening for a long time and should be addressed

@stale stale bot removed the Type: Stale Issue has become stale - automatically added by Stale bot label Jan 21, 2020
@mikehardy
Copy link
Collaborator

PRs gladly accepted, could be similar to #1820

@stale
Copy link

stale bot commented Feb 18, 2020

Hello 👋, to help manage issues we automatically close stale issues.
This issue has been automatically marked as stale because it has not had activity for quite some time. Has this issue been fixed, or does it still require the community's attention?

This issue will be closed in 15 days if no further activity occurs.
Thank you for your contributions.

@stale stale bot added the Type: Stale Issue has become stale - automatically added by Stale bot label Feb 18, 2020
@ShyamPanchal
Copy link

Facing the same issue on ios version 13.3 and Android version 8.0.0, React Native version 0.61.5 and react-native-firebase version 5.6.0.

@stale stale bot removed the Type: Stale Issue has become stale - automatically added by Stale bot label Feb 24, 2020
@stale
Copy link

stale bot commented Mar 23, 2020

Hello 👋, to help manage issues we automatically close stale issues.
This issue has been automatically marked as stale because it has not had activity for quite some time. Has this issue been fixed, or does it still require the community's attention?

This issue will be closed in 15 days if no further activity occurs.
Thank you for your contributions.

@stale stale bot added the Type: Stale Issue has become stale - automatically added by Stale bot label Mar 23, 2020
@stale
Copy link

stale bot commented Apr 7, 2020

Closing this issue after a prolonged period of inactivity. If this is still present in the latest release, please feel free to create a new issue with up-to-date information.

@pier-verdu
Copy link

Any update? I'm facing the same issue

@mikehardy
Copy link
Collaborator

@Pierre-CLIND in an open source project, all development is here. This issue has been closed for a long time, all information is contained in it. There won't be updates on closed issues typically, and asking just generates notifications for people

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Stale Issue has become stale - automatically added by Stale bot
Projects
None yet
5 participants