From 90bceb292bfcbdf16517b654376d151c26e5432c Mon Sep 17 00:00:00 2001 From: Mike Hardy Date: Sat, 10 Apr 2021 10:36:09 -0500 Subject: [PATCH] fix(crashlytics, ios): register library with dynamic version string internal registration of version should not use a hard-coded version string as we will forget to update it (which we had done...) - use the shared / dynamic version string --- .../ios/RNFBCrashlytics/RNFBCrashlyticsInitProvider.m | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/packages/crashlytics/ios/RNFBCrashlytics/RNFBCrashlyticsInitProvider.m b/packages/crashlytics/ios/RNFBCrashlytics/RNFBCrashlyticsInitProvider.m index 15a4a3d03d..878935a431 100644 --- a/packages/crashlytics/ios/RNFBCrashlytics/RNFBCrashlyticsInitProvider.m +++ b/packages/crashlytics/ios/RNFBCrashlytics/RNFBCrashlyticsInitProvider.m @@ -21,7 +21,8 @@ #import "RNFBPreferences.h" #import "RNFBJSON.h" #import "RNFBMeta.h" -#import "RNFBApp/RNFBSharedUtils.h" +#import "RNFBVersion.h" +#import "RNFBSharedUtils.h" NSString *const KEY_CRASHLYTICS_DEBUG_ENABLED = @"crashlytics_debug_enabled"; NSString *const KEY_CRASHLYTICS_AUTO_COLLECTION_ENABLED = @"crashlytics_auto_collection_enabled"; @@ -31,7 +32,7 @@ @implementation RNFBCrashlyticsInitProvider + (void)load { - [FIRApp registerInternalLibrary:self withName:@"react-native-firebase-crashlytics" withVersion:@"11.3.0"]; + [FIRApp registerInternalLibrary:self withName:@"react-native-firebase-crashlytics" withVersion:RNFBVersionString]; } + (BOOL)isCrashlyticsCollectionEnabled {