Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Purchase order doesn't find all components - and uses wrong currency #6647

Open
2 of 4 tasks
tomse opened this issue Mar 5, 2024 · 23 comments
Open
2 of 4 tasks

Purchase order doesn't find all components - and uses wrong currency #6647

tomse opened this issue Mar 5, 2024 · 23 comments
Labels
bug Identifies a bug which needs to be addressed import / export Data importing, exporting and processing question This is a question
Milestone

Comments

@tomse
Copy link

tomse commented Mar 5, 2024

Please verify that this bug has NOT been raised before.

  • I checked and didn't find a similar issue

Describe the bug*

So I'm trying out a purchase order and import a .csv - all the components are added beforehand.
Some components are shown in step 3 of the import, and some are not - red circles in the screenshots.

(should I make a new bug report for the currency?)
My currency default is Danish Kr., but for this supplier I've chosen USD. (see yellow circles)
How can I make a selection that everything should be in USD? having 20+ different components is tedious to change.

image

Here you can see one of the individual parts that aren't to find for the same supplier partnumber (column selection naming would be nice if they also are the same as Step 2 in the csv import).
image

Steps to Reproduce

Make an order, make sure all the components have been added beforehand.
Get a CSV with your order and upload it.

Expected behaviour

all the missing component fields should be filled out.

Deployment Method

  • Docker
  • Bare metal

Version Information

[0.13.5]

Please verify if you can reproduce this bug on the demo site.

  • I can reproduce this bug on the demo site.

Relevant log output

No response

@tomse tomse added bug Identifies a bug which needs to be addressed question This is a question triage:not-checked Item was not checked by the core team labels Mar 5, 2024
@tomse
Copy link
Author

tomse commented Mar 5, 2024

LCSC_Exported.csv

Attached is my CSV file

@SchrodingersGat SchrodingersGat added import / export Data importing, exporting and processing and removed triage:not-checked Item was not checked by the core team labels Mar 6, 2024
@SchrodingersGat
Copy link
Member

(should I make a new bug report for the currency?)
My currency default is Danish Kr., but for this supplier I've chosen USD. (see yellow circles)
How can I make a selection that everything should be in USD? having 20+ different components is tedious to change.

Please raise a new issue for this. The importer for purchase order items does not currently support switching currency AFAIK. So this would need to be implemented

@SchrodingersGat
Copy link
Member

Regarding this issue - For line number 4, in the drop-down menu can you find and select the c131154 component?

@tomse
Copy link
Author

tomse commented Mar 7, 2024

Regarding this issue - For line number 4, in the drop-down menu can you find and select the c131154 component?

unfortunately no

image

image

@SchrodingersGat
Copy link
Member

unfortunately no

That's very weird then. Can you find the supplier part in the global search drop-down (magnifying glass icon in the top right of the screen)?

@tomse
Copy link
Author

tomse commented Mar 12, 2024

very weird indeed..

yes, I can also find it in "Parts" search/filter box

here is a partial search for "c13"
image

The components have all been added using kintree (don't know if that helps).

I'm really at a loss here.. I've been trying to see any differences between a found component and unfound component.

Running in docker, are there any logs I can look in to supply more data?

@SchrodingersGat
Copy link
Member

@tomse I cannot think of any more tests to run for this. It is very strange.

In the "import" window, when you type something (e.g. "C13") into the drop-down menu, can you show the API request and response data? This is available in the "developer" tab in your browser

@tomse
Copy link
Author

tomse commented Mar 14, 2024

@SchrodingersGat I hope the following screenshots are what you're requesting

by import window I'm understanding this one?
image

image

image

image

image

@SchrodingersGat
Copy link
Member

@tomse no that's just for notification fetching. You'll need to capture while you are typing into the box. It should send a search query with the text you type, back to the server

@tomse
Copy link
Author

tomse commented Mar 14, 2024

@SchrodingersGat I'm not sure if I'm doing this correctly
Using firefox:
Step 3 in uploading csv.

Web Developer Tools

  • Network (is the only place I can find request/response)

"ALL" seems messy - specially under Response where I get a truncated html output with 40k lines
image

@SchrodingersGat
Copy link
Member

  1. You can filter by XHR
  2. Just before you select the drop-down, clear the log
  3. As you type you should see the requests going to the server

@tomse
Copy link
Author

tomse commented Mar 14, 2024

I'm doing something wrong.. sorry.. web dev tools is not something I'm fluent in.. not even 1%
I cleared "something" and now the request/response are empty, even after reloading the page.
it would probably be best that you describe in better detail what I need to do, I'm ok in switching browser is that is your preference

I do get this filter output in another window, but it doesn't matter if I select request/response, it shows the same

image

@wolflu05
Copy link
Contributor

What @SchrodingersGat meant was doinging the following with the Select input where you have the issues (this was using chrome, but should work with firefox too):

out.mp4

@tomse
Copy link
Author

tomse commented Mar 14, 2024

what am I doing wrong? (make note I expect we are in the step 3 of uploading the csv rather than adding a new part)

2024-03-14.13-48-18.mp4

@SchrodingersGat
Copy link
Member

@tomse that looks correct. What request data is being sent?

  • URL
  • Headers
  • Parameters

It looks like the response is empty. For the response:

  • What is the return code?
  • Headers

@tomse
Copy link
Author

tomse commented Mar 14, 2024

I noticed a new webserver and settings in the docker .env file.. is that something to look into?

is this what you're asking for?
image

@SchrodingersGat
Copy link
Member

SchrodingersGat commented Mar 15, 2024

@tomse huh, looking into the code it appears that this import method does not make use of the API. The options for each drop-down are pre-rendered on the server...

This is all going to be totally refactored as part of our roadmap to fix the import/export interface. Perhaps you would be willing to contribute funding towards this feature?

@tomse
Copy link
Author

tomse commented Mar 15, 2024

@SchrodingersGat done :-)

@SchrodingersGat
Copy link
Member

@tomse thanks! In the mean time, you could also use the admin import functionality to get your data into the system? This one edge case is very strange.

Copy link
Contributor

This issue seems stale. Please react to show this is still important.

@github-actions github-actions bot added the inactive Indicates lack of activity label May 15, 2024
@tomse
Copy link
Author

tomse commented May 16, 2024

strange didn't get a notification other than the bot.. should we keep the issue open ?

@SchrodingersGat
Copy link
Member

@tomse I will keep it open as it is referenced by a PR which will address it: #6911

@SchrodingersGat SchrodingersGat removed the inactive Indicates lack of activity label May 16, 2024
@SchrodingersGat SchrodingersGat added this to the 0.16.0 milestone May 16, 2024
@tomse
Copy link
Author

tomse commented May 20, 2024

@tomse I will keep it open as it is referenced by a PR which will address it: #6911

Thanks mate :-)

@SchrodingersGat SchrodingersGat modified the milestones: 0.16.0, 0.17.0 Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Identifies a bug which needs to be addressed import / export Data importing, exporting and processing question This is a question
Projects
None yet
Development

No branches or pull requests

3 participants