Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Platform Header Tabs vanish on refresh #6471

Open
CodingPupper3033 opened this issue Feb 12, 2024 Discussed in #6470 · 0 comments · May be fixed by #6472
Open

Platform Header Tabs vanish on refresh #6471

CodingPupper3033 opened this issue Feb 12, 2024 Discussed in #6470 · 0 comments · May be fixed by #6472
Assignees
Labels
bug Identifies a bug which needs to be addressed Platform UI Related to the React based User Interface
Milestone

Comments

@CodingPupper3033
Copy link
Contributor

Discussed in #6470

Originally posted by CodingPupper3033 February 12, 2024
Hello! I've been trying to wrap my head around the new ui's source code, and I can't figure something out.

In Headers.tsx, function NavTabs, we have the variable tabValue to tell the tabs which one it's on. It uses parameters, so I looked at the router.tsx file, and I don't see any :tabValue, so how does the value get set?

Also, I think there's a minor bug based on this where if you use the browser bar to navigate to a page and not a tab, the header (and just the header) will think you're on the default home page. It's not a critical bug, but it exists.

Issue:
The header tabs value is set to be a react-router dom parameter; however, the parameter is not set in the router. This means that on a refresh or navigating to the URL directly, the tab will be incorrectly labeled as the Home tab (default tab).

I still can't figure out how to assign labels and the issue to myself, but I have a fix. I'll try uploading it!

@matmair matmair added bug Identifies a bug which needs to be addressed Platform UI Related to the React based User Interface labels Feb 12, 2024
@matmair matmair added this to the 0.14.0 milestone Feb 12, 2024
@SchrodingersGat SchrodingersGat modified the milestones: 0.14.0, 0.15.0 Feb 26, 2024
@SchrodingersGat SchrodingersGat modified the milestones: 0.15.0, 0.16.0 Apr 25, 2024
@SchrodingersGat SchrodingersGat modified the milestones: 0.16.0, 0.17.0 Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Identifies a bug which needs to be addressed Platform UI Related to the React based User Interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants