Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Squash migrations for 1.0 #5015

Open
Tracked by #6417
matmair opened this issue Jun 10, 2023 · 3 comments
Open
Tracked by #6417

Squash migrations for 1.0 #5015

matmair opened this issue Jun 10, 2023 · 3 comments
Labels
CI CI / unit testing ecosystem refactor setup Relates to the InvenTree setup / installation process
Milestone

Comments

@matmair
Copy link
Member

matmair commented Jun 10, 2023

We currently ship a lot of migrations that are run in order; even on new instances. I suggest shipping 1.0 with squashed migrations and removing the old migrations with the next version. There would need to be a check that versions below 0.x can not be upgraded to a version > 1.x

@matmair matmair added CI CI / unit testing ecosystem setup Relates to the InvenTree setup / installation process refactor labels Jun 14, 2023
@matmair matmair added this to the 1.0.0 milestone Jun 14, 2023
@matmair
Copy link
Member Author

matmair commented Jun 14, 2023

I made a POC of how that could look like. For this to happen we need at least a week or so of database change freeze to
a) make the patch (will take a few hours probably)
b) have the change running for a few days to be sure it does not destroy instance

@SchrodingersGat
Copy link
Member

@matmair that looks nice, I was expecting we'd have to have a breaking change here but, if I read it correctly, this is a "drop in" replacement for an existing setup?

I'd like to ensure we have #4973 working before this point

@matmair
Copy link
Member Author

matmair commented Jun 15, 2023

@SchrodingersGat yes, that is the idea. Will speed up startups as well in my experience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI CI / unit testing ecosystem refactor setup Relates to the InvenTree setup / installation process
Projects
None yet
Development

No branches or pull requests

2 participants