-
-
Notifications
You must be signed in to change notification settings - Fork 852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Error in display of SVG when creating reports - Weasyprint will need to be upgraded #4936
Comments
@miggland Thanks for the report! We are pinned to 54.3 due to problems between django-weasyprint and newer weasyprint that popped up. How much of an impact has this error? I personally do not use svgs that are affected but sounds like something pretty severe. Do you have any idea how widely used |
In my limited understanding, The impact is big if the SVG is affected, but since there is a workaround, it can be handled. Since there seems to be a fix on the way for The issues with merging PDF pages should be fixed in the newest Weasyprint. The "good reason to update" may be this issue with SVGs. |
This issue seems stale. Please react to show this is still important. |
Still relevant, but the required PR is not merged yet (not much happening in |
The relevant PR is now merged. Unclear when the updated version will be released. |
This issue seems stale. Please react to show this is still important. |
not stale |
Please verify that this bug has NOT been raised before.
Describe the bug*
When creating a report with an SVG embedded in it via a link, there is a display error. It's our logo, and half of it is missing.
When I run Weasyprint 59.0 with the same source code on a different computer, the PDF looks like it should.
I believe this is caused by a bug in Weasyprint )Kozea/WeasyPrint#1864), which has been fixed in version 59.0.
At the moment, we can not update the version of Weasyprint to 59.0 because of an incompatibility with
django-weasyprint
, as described here:fdemmer/django-weasyprint#71
Until this PR is merged in
django-weasyprint
, weasyprint can not be updated. For now, there is not InvenTree can do.Workarounds:
Steps to Reproduce
<use ...>
tags<use ...>
in the PDF vainExpected behaviour
Same as with 59.0
Deployment Method
Version Information
Current master has:
weasyprint==54.3
Bug remains with
weasyprint==58.0
Relevant log output
No response
The text was updated successfully, but these errors were encountered: