Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create @auto-it/schema package #449

Open
zephraph opened this issue May 30, 2019 · 3 comments
Open

Create @auto-it/schema package #449

zephraph opened this issue May 30, 2019 · 3 comments
Labels
enhancement New feature or request

Comments

@zephraph
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

When trying to pull in the default config settings or some of the types for the config for autobot I've struggled with how intertwined some of the internals for auto are.

I'd like to split config types and defaults out into a separate package.

Describe the solution you'd like

A package called @auto-it/schema or @auto-it/config-schema or @auto-it/config (whatever works).

This package would consist primarily of two things:

  1. Detailed ts definitions for the config
  2. Any config defaults

Describe alternatives you've considered

Additional context

One of the big values of this approach is it ensures you're not pulling in any other dependency that auto may rely on but isn't needed specifically for this info. I'm running autobot in lambdas so every byte counts.

Try to faff with tree shaking but it was a bit non-trivial with the current architecture.

@zephraph zephraph added the enhancement New feature or request label May 30, 2019
@zephraph
Copy link
Collaborator Author

I can tackle this as a follow up to the launch of autobot.

@hipstersmoothie
Copy link
Collaborator

#998 should make this pretty trivial

@hipstersmoothie
Copy link
Collaborator

What might make this hard is that plugins need to tap into auto for validation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants