Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request body not included in params when issuing a PATCH request #335

Closed
wants to merge 4 commits into from

Conversation

FreakenK
Copy link
Contributor

The params hash does not contain parameters contained in the request body when issuing a PATCH request. Commit fixes this issue.

@dblock
Copy link
Member

dblock commented Feb 13, 2013

Thanks. I'd like to merge this. It needs a test and a line in CHANGELOG, please.

@FreakenK
Copy link
Contributor Author

After digging a little deeper and after reading a couple of old related issues, we found the "real" place where the fix should be put.

@FreakenK FreakenK closed this Feb 13, 2013
@FreakenK FreakenK reopened this Feb 13, 2013
@FreakenK
Copy link
Contributor Author

Here you go. I also added a test case for a PUT request since there was none (only 1 test for POST with a misleading comment stating that the test was for POST/PUT).

@dblock
Copy link
Member

dblock commented Feb 13, 2013

Committed in f72135b with some changes to specs, thank you!

@dblock dblock closed this Feb 13, 2013
@nbulaj nbulaj mentioned this pull request May 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants