Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added cookie deletion params #293

Merged
merged 1 commit into from
Dec 29, 2012
Merged

added cookie deletion params #293

merged 1 commit into from
Dec 29, 2012

Conversation

yaroslav-ilin
Copy link
Contributor

w/o such modification API servers ain't able to remove cookies set for different paths

e.g.:
cookies[:token] = { value: 'here is a token cookie', path: '/', httponly: true }
won't be deleted by simply
cookies.delete :token
instead you have to pass additional path option to remove proper cookie
cookies.delete :token, path: '/'

tested on Firefox 18 Mac, Ruby 1.9.3

w/o such modification API servers ain't able to remove cookies set for different paths
@dblock
Copy link
Member

dblock commented Dec 23, 2012

This needs a test, please and an entry in CHANGELOG.

@yaroslav-ilin
Copy link
Contributor Author

Sorry I'm not familiar w/ testing on Ruby yet.
Will be able to make test only next month.

@dblock
Copy link
Member

dblock commented Dec 24, 2012

No problem, looking forward to your contribution.

@dblock dblock merged commit 8e8d74e into ruby-grape:master Dec 29, 2012
@dblock
Copy link
Member

dblock commented Dec 29, 2012

Fyi, I merged the change, fixed it for Ruby 1.8.7, updated README, wrote a spec and added to CHANGELOG, see a65068b.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 8e8d74e on nilfalse:master into * on intridea:master*.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants