Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make API version to return it's value #248

Merged
merged 3 commits into from
Sep 23, 2012
Merged

Conversation

NARKOZ
Copy link
Contributor

@NARKOZ NARKOZ commented Sep 22, 2012

Regarding #198

@dblock
Copy link
Member

dblock commented Sep 23, 2012

So this would work, but why do we want both version and versions? Wouldn't it be logical to be able to only set version and to only get versions?

@NARKOZ
Copy link
Contributor Author

NARKOZ commented Sep 23, 2012

What about backwards compatibility? If people use versions this can brake their apps.
I think it's better to make versions as alias for version.

@dblock
Copy link
Member

dblock commented Sep 23, 2012

You may be right, although this looks broken for a while. I would be ok with version always returning the last value being set (last element of the versions array). What do you think?

@NARKOZ
Copy link
Contributor Author

NARKOZ commented Sep 23, 2012

I'm ok with it too. I've updated code accordingly. Tell me if it needs a changelog entry.

@@ -911,6 +926,9 @@ class CommunicationError < RuntimeError; end
end
end
end
it "should return version" do
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick, the description could help by saying 'should return the latest version set' or something like that.

@dblock
Copy link
Member

dblock commented Sep 23, 2012

Code looks good. A changelog entry, yes please. Will merge then.

@NARKOZ
Copy link
Contributor Author

NARKOZ commented Sep 23, 2012

Done. Also fixed a typo.

@dblock dblock merged commit ae5d155 into ruby-grape:master Sep 23, 2012
@dblock
Copy link
Member

dblock commented Sep 23, 2012

Merged, thank you for contributing and putting up with my nitpicks :)

@NARKOZ
Copy link
Contributor Author

NARKOZ commented Sep 23, 2012

Thank you. Btw, is there a some kind of schedule for releases?

@dblock dblock mentioned this pull request Sep 23, 2012
@dblock
Copy link
Member

dblock commented Sep 23, 2012

There's no schedule. I'd like to release maybe next week, but I'd like an implementation for #241 in it, still.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants