Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some tests about numberFormats #487

Merged

Conversation

PeterAlfredLee
Copy link
Member

Some users may not be familiar with numberFormats. See #481

This PR consists of some tests about minimumSignificantDigits, maximumSignificantDigits and notation. I'm trying to show some examples about the usage of these configurations. Hoping this can make it more clear.

Copy link
Member

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your feedback!

I think that issue was opened because the docs example for NumberFormat was not good docs.
So, we should be added more example cases to NumberFormat section on vue-i18n docs.

What do you think about my comment?

@PeterAlfredLee
Copy link
Member Author

So, we should be added more example cases to NumberFormat section on vue-i18n docs.

Agreed. I just pushed a new commit about it.
Feel free to let me know if there are something else to be modified. :-)

@kazupon kazupon added the Type: Documentation A documetation fixes label May 6, 2021
@kazupon
Copy link
Member

kazupon commented May 6, 2021

Thank you!
You're always so reliable. :)

@kazupon kazupon merged commit 54024fb into intlify:master May 6, 2021
@PeterAlfredLee PeterAlfredLee deleted the add_some_examples_of_numberFormats branch May 7, 2021 00:50
@PeterAlfredLee
Copy link
Member Author

You're always so reliable. :)

I'm glad this helps a little bit. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Documentation A documetation fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants