Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey guys, thank you for the plugin!
I was struggling for 2 days trying to get it working with configuring typeorm through env variables, and discovered that
fastify
always passing{}
toasync function typeormConnector (fastify, options) {
foroptions
, which makes it callcreateConnection
with that empty object even if user registered plugin without passing it. Andtypeorm.createConnection({})
seems to trying to find config in object passed and stucks, so basically that plugin does not support env-like setup. I've added couple of guards to check if passed object is empty, treat it asundefined
passed tocreateConnection
, added tests for it, updated documentation, and tested locally with myfastify
project as well.Looking forward to merge it, since its blocking my app from using env variables for
typeorm
with this cool plugin. :)