Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When forcing product image to use L size. Product images data are not returned for products that only have the L image #1535

Closed
dlakaistk opened this issue Nov 21, 2023 · 4 comments
Assignees
Labels
help wanted Extra attention is needed

Comments

@dlakaistk
Copy link

dlakaistk commented Nov 21, 2023

Actual Behavior

Force L size image for product listing as well (scaling handled by third party service) by <ish-product-image imageType="L" [link]="true"></ish-product-image>
on product-tile.component.(customization).html

Displays a not found image even though L size has been forced.

Expected Behavior
Use the L image

Steps to Reproduce the Bug

Additional Context, like Screenshots, Log File Snippets etc.

image

The second product below has a L size image
image

AB#91367

@dlakaistk dlakaistk added the bug Something isn't working label Nov 21, 2023
@dlakaistk dlakaistk changed the title Force product image to use L size. Product images data are not returned for products that only have the L image Bug when forcing product image to use L size. Product images data are not returned for products that only have the L image Nov 21, 2023
@SGrueber
Copy link
Collaborator

SGrueber commented Nov 28, 2023

@dlakaistk If you want to see L images on product listings (family pages, search pages) you have to request the L image links by the ICM server. You can do this by changing the product-list-attributes.ts file, replace 'image' by 'image@L'.
Find more information in the Product&Categories Swagger Docu

@SGrueber SGrueber self-assigned this Nov 28, 2023
@SGrueber SGrueber added help wanted Extra attention is needed and removed bug Something isn't working labels Nov 28, 2023
@dlakaistk
Copy link
Author

Hi @SGrueber

Thanks for the helpful tip and correcting the issue tag. I had a question, why is the second item in the attached screenshot not providing the L image in the output? Has it something to do with the backoffice and not the PWA?

@SGrueber
Copy link
Collaborator

@dlakaistk The product listing REST call doesn't return all images for a product from the ICM but only one image of a certain size. In the standard PWA this is size 'M'. So 'L' images cannot be shown. In my previous answer I described how you can change this and use 'L' images on product lists in your project. - For performance reason we cannot fetch all product information on listing pages in opposite to the product detail page.

@dlakaistk
Copy link
Author

Thanks @SGrueber

@dlakaistk dlakaistk changed the title Bug when forcing product image to use L size. Product images data are not returned for products that only have the L image When forcing product image to use L size. Product images data are not returned for products that only have the L image Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants