From 9a640800f0a13d58b5ec6e833537df4633ca1625 Mon Sep 17 00:00:00 2001 From: Stefan Hauke Date: Mon, 9 Nov 2020 21:42:32 +0100 Subject: [PATCH] chore: update required/tested Node.js version to 14.15.0 LTS (including npm 6.14.8) (456) BREAKING CHANGE: required Node.js version 14.15.0 LTS (including npm 6.14.8) --- .github/workflows/dead-code.yml | 4 ++-- .github/workflows/development.yml | 16 ++++++++-------- .github/workflows/docs.yml | 4 ++-- .github/workflows/integration.yml | 8 ++++---- .github/workflows/updates.yml | 4 ++-- .github/workflows/windows.yml | 8 ++++---- Dockerfile | 4 ++-- Dockerfile_reports | 2 +- docs/guides/getting-started.md | 2 +- docs/guides/migrations.md | 4 ++++ package-lock.json | 6 +++--- package.json | 6 +++--- templates/Dockerfile_dev | 2 +- tslint-rules/src/ishUsefulImportsRule.ts | 2 +- 14 files changed, 38 insertions(+), 34 deletions(-) diff --git a/.github/workflows/dead-code.yml b/.github/workflows/dead-code.yml index a575e0b7a5..6e4539b2c5 100644 --- a/.github/workflows/dead-code.yml +++ b/.github/workflows/dead-code.yml @@ -15,10 +15,10 @@ jobs: with: fetch-depth: 0 - - name: Use Node.js 12 + - name: Use Node.js 14 uses: actions/setup-node@v1 with: - node-version: 12 + node-version: 14 - name: Install root dependencies run: npm ci diff --git a/.github/workflows/development.yml b/.github/workflows/development.yml index 288e65f545..e194268c9e 100644 --- a/.github/workflows/development.yml +++ b/.github/workflows/development.yml @@ -31,10 +31,10 @@ jobs: steps: - uses: actions/checkout@v2 - - name: Use Node.js 12 + - name: Use Node.js 14 uses: actions/setup-node@v1 with: - node-version: 12 + node-version: 14 - name: Install root dependencies run: npm ci @@ -73,10 +73,10 @@ jobs: with: fetch-depth: 0 - - name: Use Node.js 12 + - name: Use Node.js 14 uses: actions/setup-node@v1 with: - node-version: 12 + node-version: 14 - name: Install root dependencies run: npm ci @@ -94,10 +94,10 @@ jobs: steps: - uses: actions/checkout@v2 - - name: Use Node.js 12 + - name: Use Node.js 14 uses: actions/setup-node@v1 with: - node-version: 12 + node-version: 14 - name: Install root dependencies run: npm ci @@ -117,10 +117,10 @@ jobs: steps: - uses: actions/checkout@v2 - - name: Use Node.js 12 + - name: Use Node.js 14 uses: actions/setup-node@v1 with: - node-version: 12 + node-version: 14 - name: Install root dependencies run: npm ci diff --git a/.github/workflows/docs.yml b/.github/workflows/docs.yml index 711c28629d..47120ea2eb 100644 --- a/.github/workflows/docs.yml +++ b/.github/workflows/docs.yml @@ -19,10 +19,10 @@ jobs: with: fetch-depth: 0 - - name: Use Node.js 12 + - name: Use Node.js 14 uses: actions/setup-node@v1 with: - node-version: 12 + node-version: 14 - name: Install root dependencies run: npm ci diff --git a/.github/workflows/integration.yml b/.github/workflows/integration.yml index 89ef37bf01..85e532e6b2 100644 --- a/.github/workflows/integration.yml +++ b/.github/workflows/integration.yml @@ -31,10 +31,10 @@ jobs: steps: - uses: actions/checkout@v2 - - name: Use Node.js 12 + - name: Use Node.js 14 uses: actions/setup-node@v1 with: - node-version: 12 + node-version: 14 - name: Install root dependencies run: npm ci @@ -61,10 +61,10 @@ jobs: steps: - uses: actions/checkout@v2 - - name: Use Node.js 12 + - name: Use Node.js 14 uses: actions/setup-node@v1 with: - node-version: 12 + node-version: 14 - name: Download Build Output uses: actions/download-artifact@v2 diff --git a/.github/workflows/updates.yml b/.github/workflows/updates.yml index 47149dfb03..82f74badc3 100644 --- a/.github/workflows/updates.yml +++ b/.github/workflows/updates.yml @@ -16,10 +16,10 @@ jobs: steps: - uses: actions/checkout@v2 - - name: Use Node.js 12 + - name: Use Node.js 14 uses: actions/setup-node@v1 with: - node-version: 12 + node-version: 14 - name: Install root dependencies run: npm ci diff --git a/.github/workflows/windows.yml b/.github/workflows/windows.yml index 25d64fe5e8..f47c4b7f17 100644 --- a/.github/workflows/windows.yml +++ b/.github/workflows/windows.yml @@ -24,10 +24,10 @@ jobs: steps: - uses: actions/checkout@v2 - - name: Use Node.js 12 + - name: Use Node.js 14 uses: actions/setup-node@v1 with: - node-version: 12 + node-version: 14 - name: Install root dependencies run: npm ci @@ -42,10 +42,10 @@ jobs: steps: - uses: actions/checkout@v2 - - name: Use Node.js 12 + - name: Use Node.js 14 uses: actions/setup-node@v1 with: - node-version: 12 + node-version: 14 - name: Install Clean Repository run: | diff --git a/Dockerfile b/Dockerfile index 57222369b5..42595b2595 100644 --- a/Dockerfile +++ b/Dockerfile @@ -1,4 +1,4 @@ -FROM node:12-alpine as buildstep +FROM node:14-alpine as buildstep WORKDIR /workspace COPY schematics /workspace/schematics/ COPY package.json package-lock.json /workspace/ @@ -21,7 +21,7 @@ RUN test "${serviceWorker}" = "true" && sed -i 's/canonicalHash !== cacheBustedH RUN egrep -o '^\s*(mockServerAPI: true|mustMockPaths)' src/environments/environment.prod.ts || rm -Rf dist/browser/assets/mock* COPY dist/entrypoint.sh dist/healthcheck.js dist/server.crt dist/server.key dist/robots.txt* /workspace/dist/ -FROM node:12-alpine +FROM node:14-alpine COPY --from=buildstep /workspace/dist /dist ARG displayVersion= LABEL displayVersion="${displayVersion}" diff --git a/Dockerfile_reports b/Dockerfile_reports index 8c4a59ddd9..5fb48886d9 100644 --- a/Dockerfile_reports +++ b/Dockerfile_reports @@ -1,4 +1,4 @@ -FROM node:12 as reporting +FROM node:14 as reporting COPY package.json package-lock.json tsconfig.base.json /workspace/ COPY tslint-rules /workspace/tslint-rules/ WORKDIR /workspace diff --git a/docs/guides/getting-started.md b/docs/guides/getting-started.md index f854ec6449..f3be29f3e9 100644 --- a/docs/guides/getting-started.md +++ b/docs/guides/getting-started.md @@ -8,7 +8,7 @@ kb_sync_latest_only # Getting Started Before working with this project, download and install [Node.js](https://nodejs.org) with the included npm package manager. -Currently Node.js 12.x LTS with the corresponding npm is required. +Currently Node.js 14.x LTS with the corresponding npm is required. This project was generated with [Angular CLI](https://github.com/angular/angular-cli) and follows the Angular CLI style guide and naming conventions. diff --git a/docs/guides/migrations.md b/docs/guides/migrations.md index fd2d71ea36..df57e631ae 100644 --- a/docs/guides/migrations.md +++ b/docs/guides/migrations.md @@ -7,6 +7,10 @@ kb_sync_latest_only # Migrations +## 0.25 to 0.26 + +The project configuration was updated to use and test with Node.js version 14.15.0 LTS (including npm 6.14.8) for any further development. + ## 0.24 to 0.25 We replaced the simple [ngx-cookie-banner](https://github.com/exportarts/ngx-cookie-banner) cookie banner with an own implementation that provides the means to configure and set more fine grained cookie consent options. diff --git a/package-lock.json b/package-lock.json index 1edba1609c..6857e09436 100644 --- a/package-lock.json +++ b/package-lock.json @@ -7071,9 +7071,9 @@ "dev": true }, "@types/node": { - "version": "12.19.2", - "resolved": "https://registry.npmjs.org/@types/node/-/node-12.19.2.tgz", - "integrity": "sha512-SRH6QM0IMOBBFmDiJ75vlhcbUEYEquvSuhsVW9ijG20JvdFTfOrB1p6ddZxz5y/JNnbf+9HoHhjhOVSX2hsJyA==", + "version": "14.14.7", + "resolved": "https://registry.npmjs.org/@types/node/-/node-14.14.7.tgz", + "integrity": "sha512-Zw1vhUSQZYw+7u5dAwNbIA9TuTotpzY/OF7sJM9FqPOF3SPjKnxrjoTktXDZgUjybf4cWVBP7O8wvKdSaGHweg==", "dev": true }, "@types/normalize-package-data": { diff --git a/package.json b/package.json index a6d81ea0d3..cbafe0b042 100644 --- a/package.json +++ b/package.json @@ -7,8 +7,8 @@ "intershop" ], "engines": { - "node": ">=12.13.0", - "npm": "~6.12.0" + "node": ">=14.15.0", + "npm": ">=6.14.8" }, "private": true, "scripts": { @@ -106,7 +106,7 @@ "@types/express": "^4.17.8", "@types/jest": "^26.0.15", "@types/lodash-es": "^4.17.3", - "@types/node": "^12.19.2", + "@types/node": "^14.14.7", "codelyzer": "^6.0.1", "comment-json": "^4.1.0", "commitizen": "^4.2.2", diff --git a/templates/Dockerfile_dev b/templates/Dockerfile_dev index 70fee0e3ff..fe88a17eb6 100644 --- a/templates/Dockerfile_dev +++ b/templates/Dockerfile_dev @@ -1,4 +1,4 @@ -FROM node:12 as buildstep +FROM node:14 as buildstep COPY . /workspace/ WORKDIR /workspace RUN npm ci diff --git a/tslint-rules/src/ishUsefulImportsRule.ts b/tslint-rules/src/ishUsefulImportsRule.ts index 8694cfbc7b..615dc38f9e 100644 --- a/tslint-rules/src/ishUsefulImportsRule.ts +++ b/tslint-rules/src/ishUsefulImportsRule.ts @@ -43,7 +43,7 @@ export class Rule extends Lint.Rules.AbstractRule { constructor(options: Lint.IOptions) { super(options); try { - const config = parse(fs.readFileSync('./tsconfig.base.json', { encoding: 'UTF-8' })); + const config = parse(fs.readFileSync('./tsconfig.base.json', { encoding: 'utf-8' })); if (config && config.compilerOptions && config.compilerOptions.paths) { const paths = config.compilerOptions.paths; this.shortImports = Object.keys(paths).map(key => ({