fix: submit a promotion code by pressing enter (#436)

intershop · Oct 26, 2020 · 360b649 · 360b649
1 parent c0091ea
commit 360b649
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 3 deletions.
diff --git a/...mplates/shared/product-add-to-order-template/product-add-to-order-template.component.html b/...mplates/shared/product-add-to-order-template/product-add-to-order-template.component.html
@@ -1,6 +1,6 @@
 <!-- display addToOrderTemplate Icon/animated Icon or link-->
 <button
-  type="submit"
+  type="button"
   name="addProduct"
   class="btn"
   [ngClass]="class"

diff --git a/...xtensions/wishlists/shared/product-add-to-wishlist/product-add-to-wishlist.component.html b/...xtensions/wishlists/shared/product-add-to-wishlist/product-add-to-wishlist.component.html
@@ -1,6 +1,6 @@
 <!-- display addToCart Icon/animated Icon or link-->
 <button
-  type="submit"
+  type="button"
   name="addProduct"
   class="btn btn-link add-to-wishlist"
   (click)="openModal(modal)"

diff --git a/src/app/shared/components/basket/basket-promotion-code/basket-promotion-code.component.html b/src/app/shared/components/basket/basket-promotion-code/basket-promotion-code.component.html
@@ -12,12 +12,13 @@
   <div class="form-inline" [ngbCollapse]="isCollapsed">
     <input
       [formControl]="codeInput"
+      (keydown.enter)="submitPromotionCode()"
       class="form-control"
       type="text"
       [maxlength]="codeMaxLength"
       [placeholder]="'shopping_cart.promotional_code.label' | translate"
     />
-    <button type="submit" class="btn btn-secondary" [disabled]="!codeInput.valid" (click)="submitPromotionCode()">
+    <button type="button" class="btn btn-secondary" [disabled]="!codeInput.valid" (click)="submitPromotionCode()">
       {{ 'shopping_cart.promotion.apply.button.label' | translate }}
     </button>
   </div>

diff --git a/src/app/shared/components/basket/basket-promotion-code/basket-promotion-code.component.ts b/src/app/shared/components/basket/basket-promotion-code/basket-promotion-code.component.ts
@@ -61,6 +61,8 @@ export class BasketPromotionCodeComponent implements OnInit, OnDestroy {
       this.lastEnteredPromoCode = this.codeInput.value;
     }
     this.checkoutFacade.addPromotionCodeToBasket(this.codeInput.value);
+    // prevent further form submit
+    return false;
   }
 
   ngOnDestroy() {