Skip to content

Commit

Permalink
fix: use take instead of first to prevent EmptyError on missing trans…
Browse files Browse the repository at this point in the history
…lation (#1554)
  • Loading branch information
dhhyi authored Dec 18, 2023
1 parent 76717cb commit 0904c9e
Showing 1 changed file with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import {
} from '@ngx-translate/core';
import { memoize } from 'lodash-es';
import { EMPTY, concat, defer, iif, of } from 'rxjs';
import { filter, first, map, tap } from 'rxjs/operators';
import { filter, map, take, tap } from 'rxjs/operators';

import { getSpecificServerTranslation, loadSingleServerTranslation } from 'ish-core/store/core/configuration';
import { InjectSingle } from 'ish-core/utils/injection';
Expand Down Expand Up @@ -46,7 +46,7 @@ export class FallbackMissingTranslationHandler implements MissingTranslationHand
}),
filter(translation => translation !== undefined),
map((translation: string) => this.translateCompiler.compile(translation, lang)),
first()
take(1)
)
);
}
Expand All @@ -60,7 +60,7 @@ export class FallbackMissingTranslationHandler implements MissingTranslationHand
this.reportMissingTranslation(lang, key);
}
}),
first()
take(1)
);
}

Expand Down Expand Up @@ -93,7 +93,7 @@ export class FallbackMissingTranslationHandler implements MissingTranslationHand
).pipe(
// stop after first emission
whenTruthy(),
first(),
take(1),
map(translation => this.translateParser.interpolate(translation, params.interpolateParams)),
map(translation => (PRODUCTION_MODE ? translation : `TRANSLATE_ME ${translation}`))
);
Expand Down

0 comments on commit 0904c9e

Please sign in to comment.