Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cardano-testnet: add single entrypoint for starting testnets #4544

Merged
merged 1 commit into from
Oct 31, 2022
Merged

cardano-testnet: add single entrypoint for starting testnets #4544

merged 1 commit into from
Oct 31, 2022

Conversation

MarcFontaine
Copy link
Contributor

@MarcFontaine MarcFontaine commented Oct 19, 2022 •
edited
Loading

This PR adds a single entry point for starting Shelley, Babbage and Cardano testnets.

@MarcFontaine MarcFontaine self-assigned this Oct 19, 2022
@MarcFontaine MarcFontaine added the WIP Work In Progress (cannot be merged yet) label Oct 19, 2022
@MarcFontaine MarcFontaine changed the title cardano-testnet: add single entrypoint for starting Shelley Babbage a… cardano-testnet: add single entrypoint for starting testnets Oct 19, 2022
@MarcFontaine MarcFontaine mentioned this pull request Oct 19, 2022
Closed
@MarcFontaine MarcFontaine force-pushed the mafo/4539-test-entry-point branch from 337539f to 653756a Compare October 24, 2022 13:17
@MarcFontaine MarcFontaine removed the WIP Work In Progress (cannot be merged yet) label Oct 24, 2022
@MarcFontaine MarcFontaine force-pushed the mafo/4539-test-entry-point branch 2 times, most recently from 2c4966b to 4f603c2 Compare October 25, 2022 10:56
Jimbo4350
Jimbo4350 reviewed Oct 25, 2022
View reviewed changes
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. A few comments

@MarcFontaine MarcFontaine force-pushed the mafo/4539-test-entry-point branch from 7d175cd to 7afa61a Compare October 26, 2022 07:25
@MarcFontaine
Copy link
Contributor Author

This PR is a first step towards
#4134

@MarcFontaine MarcFontaine mentioned this pull request Oct 28, 2022
Merged
Jimbo4350
Jimbo4350 requested changes Oct 30, 2022
View reviewed changes
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple minor changes. Happy to approve after.

cardano-node-chairman/test/Spec/Chairman/Cardano.hs Outdated
@@ -29,6 +30,6 @@ hprop_chairman = H.integration . H.runFinallies . H.workspace "chairman" $ \temp
configurationTemplate <- H.noteShow $ base </> "configuration/defaults/byron-mainnet/configuration.yaml"
conf <- H.mkConf (H.ProjectBase base) (H.YamlFilePath configurationTemplate) tempAbsPath' Nothing

allNodes <- fmap H.nodeName . H.allNodes <$> H.testnet H.defaultTestnetOptions conf
allNodes <- fmap H.nodeName . H.allNodes <$> H.cardanoTestnet H.defaultTestnetOptions conf
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want to call testnet here.

cardano-testnet/src/Test/Runtime.hs
import Data.Aeson (FromJSON)
import Data.Either (Either (..))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

cardano-testnet/src/Testnet/Utils.hs Outdated
@@ -26,7 +26,6 @@ import Hedgehog.Extras.Test.Process (ExecConfig)
import Hedgehog.Internal.Property (MonadTest)
import qualified Test.Process as H


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please undo this diff. It just adds noise to the PR.

@MarcFontaine MarcFontaine force-pushed the mafo/4539-test-entry-point branch from fd2e3f4 to cb9f070 Compare October 31, 2022 13:36
Jimbo4350
Jimbo4350 approved these changes Oct 31, 2022
View reviewed changes
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍 . Just squash the commits. I think bors is down so devops will need to sort that out.

@MarcFontaine MarcFontaine force-pushed the mafo/4539-test-entry-point branch from cb9f070 to ce8f70a Compare October 31, 2022 15:54
@MarcFontaine
Copy link
Contributor Author

bors r+

iohk-bors bot added a commit that referenced this pull request Oct 31, 2022
@iohk-bors @MarcFontaine
Merge #4544
94b80ed 
4544: cardano-testnet: add single entrypoint for starting testnets r=MarcFontaine a=MarcFontaine

This PR adds a single entry point for starting Shelley, Babbage and Cardano testnets.

Co-authored-by: MarcFontaine <MarcFontaine@users.noreply.github.com>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Oct 31, 2022

Build failed:

@MarcFontaine MarcFontaine force-pushed the mafo/4539-test-entry-point branch from ce8f70a to d7e8b73 Compare October 31, 2022 17:40
@MarcFontaine
Copy link
Contributor Author

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Oct 31, 2022

Build succeeded:

@iohk-bors iohk-bors bot merged commit 8ff5bed into master Oct 31, 2022
@iohk-bors iohk-bors bot deleted the mafo/4539-test-entry-point branch October 31, 2022 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jimbo4350 Jimbo4350 Jimbo4350 approved these changes

@dcoutts dcoutts Awaiting requested review from dcoutts

@erikd erikd Awaiting requested review from erikd

@newhoggy newhoggy Awaiting requested review from newhoggy

@JaredCorduan JaredCorduan Awaiting requested review from JaredCorduan

@LudvikGalois LudvikGalois Awaiting requested review from LudvikGalois

@CarlosLopezDeLara CarlosLopezDeLara Awaiting requested review from CarlosLopezDeLara

Assignees

@MarcFontaine MarcFontaine

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarcFontaine @Jimbo4350