Use new pre-commit script to detect and fix existing i18n syntax issues

[rebecca-shoptaw]

Problem

The new detect_missing_i18n script by @pidgezero-one has given us a super helpful list of i18n syntaxing issues throughout the codebase and/or valid i18n that accidentally gets flagged by the script.

These files are listed in EXCLUDE_LIST in detect_missing_i18n.py.

Proposal & Constraints

Once the PR (#9428) is merged, I propose going through the full list of excluded files myself and making any changes where needed, either fixing i18n syntax or adjusting distribution of text to avoid accidental flags of the script. I'll also make any updates to the i18n Developer's Guide where needed as a result of edge-cases I discover in the process.

Related files

detect_missing_i18n.py

Issue phases & sub-PRs

• Phase 1: Update warn regex to avoid accidentally flagging Python, escape remaining Python files as needed.
  • PR: Update i18n warn regex and escape relevant files #9502
• Phase 2: Complete all basic i18n syntax updates, i.e. adding $_(" ") or $_(' ') to all plain text or title/alt/placeholder attributes
  • PR: Basic i18n syntax additions #9505
• Phase 3: Complete all i18n syntax updates that include variables, i.e. $_('%(count)d titles by %(author)s', count=num_titles, author=author_name)
  • PR: i18n syntax additions with variables #9506
• Phase 4: Complete all i18n syntax updates that include nested HTML, i.e. $:_('Please <a href="">click here</a>')
  • PR: i18n syntax additions with nested HTML #9507
• Phase 5: Add any remaining exceptions or exclusions where necessary
  • PR: Update i18n exclude list and add remaining exceptions where needed #9508
• Phase 6: Address any errors created by the changes
  • PR: Change i18n rendering for edition_count in lazy work preview #9708

Stakeholders

@pidgezero-one

---

Instructions for Contributors

• Please run these commands to ensure your repository is up to date before creating a new branch to work on this issue and each time after pushing code to Github, because the pre-commit bot may add commits to your PRs upstream.

[rebecca-shoptaw]

All subtasks complete and merged!