Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Star Ratings & Want To Read counts to Search Result Cards #9463

Closed
mekarpeles opened this issue Jun 21, 2024 · 3 comments · Fixed by #9790
Closed

Add Star Ratings & Want To Read counts to Search Result Cards #9463

mekarpeles opened this issue Jun 21, 2024 · 3 comments · Fixed by #9790
Assignees
@merwhite11
Labels
Affects: Experience Issues relating directly to service design & patrons experience Fellowship Opportunity Good First Issue Easy issue. Good for newcomers. [managed] Lead: @mekarpeles Issues overseen by Mek (Staff: Program Lead) [managed] Module: Search Page(s) Issues pertaining to the Search page UI Priority: 2 Important, as time permits. [managed] Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed]
Milestone
Sprint 2024-09

Comments

@mekarpeles
Copy link
Member

mekarpeles commented Jun 21, 2024 •
edited
Loading

Problem

A clear and concise description of what you want to happen

A line should be added below the byline which shows the star ratings and want to read counts

Expected behaviour / screenshots (ex: Figma design screenshots for UI feature)

image

Leads

Related files

Stakeholders

Instructions for Contributors

  • Please run these commands to ensure your repository is up to date before creating a new branch to work on this issue and each time after pushing code to Github, because the pre-commit bot may add commits to your PRs upstream.
@mekarpeles mekarpeles added Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed] Good First Issue Easy issue. Good for newcomers. [managed] Priority: 2 Important, as time permits. [managed] Lead: @mekarpeles Issues overseen by Mek (Staff: Program Lead) [managed] Affects: Experience Issues relating directly to service design & patrons experience Module: Search Page(s) Issues pertaining to the Search page UI Fellowship Opportunity labels Jun 21, 2024
@mekarpeles mekarpeles mentioned this issue Jun 21, 2024
Open
@mekarpeles mekarpeles added this to the Sprint 2024-07 milestone Jul 5, 2024
@siddharthbaleja7
Copy link

@mekarpeles Can you please assign this issue to me.

@github-actions github-actions bot added the Needs: Response Issues which require feedback from lead label Jul 25, 2024
@mekarpeles mekarpeles changed the title Add Star Ratings & Want To Read to Search Result Cards Add Star Ratings & Want To Read counts to Search Result Cards Aug 2, 2024
@wowthedoge
Copy link

@mekarpeles Hi, can I have a go at this?

@mekarpeles
Copy link
Member Author

@wowthedoge, @merwhite11 is currently working on a PR for this one :) thank you so much for the kind offer.

Here are a few issues where contributions may be welcome!
https://github.com/internetarchive/openlibrary/issues?q=is%3Aopen+is%3Aissue+-label%3A%22Needs%3A+Breakdown%22%2C%22Needs%3A+Lead%22%2C%22Needs%3A+Designs%22%2C%22Needs%3A+Triage%22+label%3A%22Good+first+issue%22+no%3Aassignee+is%3Aopen+-linked%3Apr

@mekarpeles mekarpeles removed the Needs: Response Issues which require feedback from lead label Aug 19, 2024
@merwhite11 merwhite11 mentioned this issue Aug 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@merwhite11 merwhite11

Labels
Affects: Experience Issues relating directly to service design & patrons experience Fellowship Opportunity Good First Issue Easy issue. Good for newcomers. [managed] Lead: @mekarpeles Issues overseen by Mek (Staff: Program Lead) [managed] Module: Search Page(s) Issues pertaining to the Search page UI Priority: 2 Important, as time permits. [managed] Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed]
Projects
None yet
Milestone
Sprint 2024-09
Development

Successfully merging a pull request may close this issue.

Add Star Ratings & Want To Read counts to Search Result Cards merwhite11/openlibrary
4 participants
@mekarpeles @wowthedoge @merwhite11 @siddharthbaleja7