Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix patron block and revert functionality where /type/delete encountered #4045

Closed
1 task
mekarpeles opened this issue Nov 7, 2020 · 1 comment · Fixed by #9013
Closed
1 task

Fix patron block and revert functionality where /type/delete encountered #4045

mekarpeles opened this issue Nov 7, 2020 · 1 comment · Fixed by #9013
Assignees
@benbdeitch
Labels
Affects: Admin/Maintenance Issues relating to support scripts, bots, cron jobs and admin web pages. [managed] Affects: Data Issues that affect book/author metadata or user/account data. [managed] Data Cleanup Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] Needs: Investigation This issue/PR needs a root-cause analysis to determine a solution. [managed] Priority: 2 Important, as time permits. [managed] Type: Bug Something isn't working. [managed]

Comments

@mekarpeles
Copy link
Member

mekarpeles commented Nov 7, 2020 •
edited
Loading

In #711 there is a case where a user has been blocked. There is an issue with reverting all of their changes because one of them has already been deleted and is registering as /type/delete instead of /type/author.

<class 'infogami.infobase.client.ClientException'> at /admin/people/AliceKirk/edits
expected /type/author, found /type/delete

Python | /opt/openlibrary/deploys/openlibrary/824a904/infogami/infobase/client.py in handle_error, line 84
POST https://openlibrary.org/admin/people/AliceKirk/edits

Success criteria:

  • an admin should revert all of AliceKirk

Originally posted by @mekarpeles in #711 (comment)
@mekarpeles mekarpeles mentioned this issue Nov 7, 2020
Closed
@mekarpeles mekarpeles added Affects: Admin/Maintenance Issues relating to support scripts, bots, cron jobs and admin web pages. [managed] Affects: Data Issues that affect book/author metadata or user/account data. [managed] Data Cleanup Needs: Help Issues, typically substantial ones, that need a dedicated developer to take them on. [managed] Priority: 2 Important, as time permits. [managed] Type: Bug Something isn't working. [managed] labels Nov 7, 2020
@cdrini cdrini added this to the Next (proposed) milestone Jan 4, 2021
@cdrini cdrini added Needs: Investigation This issue/PR needs a root-cause analysis to determine a solution. [managed] Lead: @mekarpeles Issues overseen by Mek (Staff: Program Lead) [managed] and removed Needs: Help Issues, typically substantial ones, that need a dedicated developer to take them on. [managed] labels Jan 4, 2021
@cdrini cdrini modified the milestones: Next (proposed), Active Sprint Jan 4, 2021
@mekarpeles mekarpeles removed this from the Next (proposed) milestone Apr 4, 2022
@cdrini cdrini added Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] and removed Lead: @mekarpeles Issues overseen by Mek (Staff: Program Lead) [managed] labels Apr 2, 2024
@benbdeitch
Copy link
Collaborator

Hello! Could you assign me to this issue?

@benbdeitch benbdeitch mentioned this issue Apr 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benbdeitch benbdeitch

Labels
Affects: Admin/Maintenance Issues relating to support scripts, bots, cron jobs and admin web pages. [managed] Affects: Data Issues that affect book/author metadata or user/account data. [managed] Data Cleanup Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] Needs: Investigation This issue/PR needs a root-cause analysis to determine a solution. [managed] Priority: 2 Important, as time permits. [managed] Type: Bug Something isn't working. [managed]
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix deleted work prevents reverting a user's works benbdeitch/openlibraryfork
3 participants
@mekarpeles @cdrini @benbdeitch