Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Bitcoin core 25 #448

Open
nud3l opened this issue Feb 12, 2023 · 3 comments
Open

Support Bitcoin core 25 #448

nud3l opened this issue Feb 12, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@nud3l
Copy link
Member

nud3l commented Feb 12, 2023

Is your feature request related to a problem? Please describe.

Vaults are currently using Bitcoin core 22. Bitcoin core 24 comes with support for more features and in the spirit of keeping dependencies up to date, we want to make sure we support the latest major release versions.

Describe the solution you'd like

Tests and add support for Bitcoin core 25. Make this the standard option for Vaults.

Additional context

Bitcoin core from version 23 comes with descriptor wallets by default.

@nud3l nud3l added the enhancement New feature or request label Feb 12, 2023
@sander2
Copy link
Member

sander2 commented Feb 13, 2023

The main issue with bitcoin 23 was that it uses descriptor wallets by default

@sander2
Copy link
Member

sander2 commented Feb 17, 2023

The strategy will be to call createwallet with descriptor=false, for which I made the upstream pr: rust-bitcoin/rust-bitcoincore-rpc#278

@nud3l
Copy link
Member Author

nud3l commented Mar 6, 2023

Related, I think we should switch to using descriptor wallets: #457

@nud3l nud3l changed the title Support Bitcoin core 24 Support Bitcoin core 25 Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Todo
Development

No branches or pull requests

3 participants
@sander2 @nud3l and others