Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace rand_os with getrandom (closes #23) #90

Merged
merged 1 commit into from
Dec 11, 2019

Conversation

tarcieri
Copy link
Contributor

rand_os is just a wrapper for getrandom. I believe the long-term plan is to deprecrate it entirely.

@tarcieri tarcieri changed the title Replace rand_os with getrandom Replace rand_os with getrandom (closes #23) Dec 11, 2019
`rand_os` is just a wrapper for `getrandom`. I believe the long term
plan is to deprecrate it entirely.
@tarcieri tarcieri force-pushed the replace-rand_os-with-getrandom branch from fd22b2d to a202037 Compare December 11, 2019 20:28
Copy link
Member

@liamsi liamsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be a formatting issue but other than that the changes look good to me. (and yes the rand_os crate is deprecated / is just a shim for getrandom anyways).

@tarcieri
Copy link
Contributor Author

rustfmt is fixed

Copy link
Member

@liamsi liamsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@liamsi liamsi merged commit db16953 into master Dec 11, 2019
@liamsi liamsi deleted the replace-rand_os-with-getrandom branch December 11, 2019 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants