Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(stub files): remove the majority of stub files #899

Merged
merged 3 commits into from
Jul 1, 2022
Merged

docs(stub files): remove the majority of stub files #899

merged 3 commits into from
Jul 1, 2022

Conversation

Catalyst4222
Copy link
Contributor

About

This pull request removes nearly every .pyi file

The pyi files are supposed to help with typehints, but after the attrs pr, none of them add much to typehints.
This pr removes almost all of them, and instead adds in inline typehints, which will reduce the work needed for adding new functions and classes
The only pyi file left in is attr_utils.pyi, since it has to set up one of the functions as a dataclass field

Checklist

  • I've ran pre-commit to format and lint the change(s) made.
  • I've checked to make sure the change(s) work on 3.8.6 and higher.
  • This fixes/solves an Issue.
    • (If existent):
  • I've made this pull request for/as: (check all that apply)
    • Documentation
    • Breaking change
    • New feature/enhancement
    • Bugfix

@Catalyst4222 Catalyst4222 marked this pull request as ready for review June 30, 2022 18:47
@Catalyst4222 Catalyst4222 requested a review from EepyElvyra June 30, 2022 18:50
@Catalyst4222
Copy link
Contributor Author

The merge conflict is happening because someone changed a file that I deleted, but there's no way for me to resolve it
image

@EepyElvyra
Copy link
Contributor

The merge conflict is happening because someone changed a file that I deleted, but there's no way for me to resolve it image

Merge unstable into your branch, commit, delete the files again, commit?

# Conflicts:
#	interactions/api/error.pyi
@Catalyst4222
Copy link
Contributor Author

Resolved the conflict

@EepyElvyra EepyElvyra enabled auto-merge (squash) June 30, 2022 19:02
@Catalyst4222 Catalyst4222 requested a review from AstreaTSS July 1, 2022 15:48
@EepyElvyra EepyElvyra merged commit e462f29 into interactions-py:unstable Jul 1, 2022
@FayeDel FayeDel linked an issue Jul 1, 2022 that may be closed by this pull request
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Change Presence pyi signature is synchronous
2 participants