Skip to content
This repository has been archived by the owner on Nov 8, 2022. It is now read-only.

Remove metric.String() #34

Closed
kindermoumoute opened this issue Oct 10, 2016 · 2 comments
Closed

Remove metric.String() #34

kindermoumoute opened this issue Oct 10, 2016 · 2 comments
Labels
bug tracked

Comments

@kindermoumoute
Copy link
Contributor

kindermoumoute commented Oct 10, 2016 •
edited
Loading

This method Metric.Namespace.String() should be updated now Snap PR 1252 is merged.
@bjray bjray changed the title Update metric.String() for arbitrary separator Remove metric.String() Oct 18, 2016
@bjray
Copy link

bjray commented Oct 18, 2016

We updated the issue name to focus on the removal of this functionality.

Providing a string method implies a guarantee that we are not going to make. The recommendation will be to remove this method and leave any implementation up to the plugin author.

@candysmurf candysmurf mentioned this issue Oct 20, 2016
Merged
@IRCody
Copy link
Contributor

IRCody commented Nov 2, 2016

Closing this as it was addressed by #1301.

@IRCody IRCody closed this as completed Nov 2, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug tracked
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@bjray @IRCody @kindermoumoute @snapbot