fix for correctly handling AWS Secrets #2567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
I am early merging it to enable the user here to solve their problem. In case, please feel free to suggest any changes even afterwards |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for @drosetti : I added a boolean environment variable for the integration with Elastic to avoid to have empty ("None") environment variables. This would have created problems in case the AWS_SECRETS variable was enabled.
More generally, it would also make more sense to have that boolean flag to enable/disable the feature instead of leveraging an URL-based variable. In this way you don't have to configure the URL multiple times in case of changes but you have to configure a more easily understandable boolean flag.
I updated the doc too: intelowlproject/docs@ecb7c72