Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ja4db analyzer, closes #2361 #2402
ja4db analyzer, closes #2361 #2402
Changes from 1 commit
a2112fb
625419f
aecfefc
94af380
29ca1ac
2013be7
05434fd
311d3e9
a65a57b
9451389
1532b9d
185d2f8
2c9103b
fdbde86
15657cd
323af6b
5883152
26f1627
8621aca
bdeb978
325e314
c20d77d
6663f30
c435bf8
27da5f0
18d5bff
dd8f379
f508b89
44d4b26
a0f0b22
4092538
af7e3e5
657f348
4f8a95c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah one last thing. Considering that this analyzer is "generic" and we don't have a ja4 type, we could do some trick here too to avoid useless computation and, at the same time, to avoid that this analyzer fails.
https://github.com/FoxIO-LLC/ja4
We could check the length at least, as a very simple filter.
In case the length does not fit, we can just avoid to open the file at all and report back "this is not a ja4 hash cause the string is too short/long" or something like that.
Honestly I did not find a place where they say how long these fingerprints must be. The length seems to change. I would put a safeguard of minimum 20 chars and maximum 70 or something like that if we don't find better