Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is iHD driver thread-safe? #1093

Closed
daijh opened this issue Nov 24, 2020 · 1 comment
Closed

Is iHD driver thread-safe? #1093

daijh opened this issue Nov 24, 2020 · 1 comment
Assignees
Labels
Question/Discussion Issue: question for media driver Reserved Information to describe some implementation detail or restriction

Comments

@daijh
Copy link
Contributor

daijh commented Nov 24, 2020

A recent libva PR imposed the requirement that all backends must be thread-safe.
Does iHD driver implement comply with this libva thread-safe statement?

All VAAPI functions implemented in libva are thread-safe. For any VAAPI
function that requires the implementation of a backend (e.g. hardware driver),
the backend must ensure that its implementation is also thread-safe. If the
backend implementation of a VAAPI function is not thread-safe then this should
be considered as a bug against the backend implementation.

Update va.h for multi-threaded usages intel/libva#347

Thanks for the clarification.

@XinfengZhang
Copy link
Contributor

XinfengZhang commented Nov 25, 2020

yes, iHD implementation comply with the libva thread-safe statement.
it was tested by https://github.com/Intel-Media-SDK/samples/tree/master/samples/sample_multi_transcode.
if there are thread safe issue, please report ,it, maintainers will fix it.

please also pay attention on these statement of libva:

When multiple threads are operating on
the same VAAPI objects, it is the application's responsibility to synchronize
these operations in order to generate the expected results. For example, using
a single VAContext from multiple threads may generate unexpected results.

@XinfengZhang XinfengZhang added Question/Discussion Issue: question for media driver Reserved Information to describe some implementation detail or restriction labels Dec 31, 2020
@XinfengZhang XinfengZhang self-assigned this Dec 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Question/Discussion Issue: question for media driver Reserved Information to describe some implementation detail or restriction
Projects
None yet
Development

No branches or pull requests

2 participants