From 49fecfc1aea989ebb3941c576f499236bbc1e070 Mon Sep 17 00:00:00 2001 From: Isaac Ault Date: Wed, 19 Jun 2024 10:33:56 +0100 Subject: [PATCH] Address Feedback: * Remove const from non-reference and non-pointer type parameters (cherry picked from commit b73ddff7300f559f038307f83c9da6eea572ea27) --- .../sycl_ext_oneapi_bindless_images.asciidoc | 8 ++++---- sycl/include/sycl/ext/oneapi/bindless_images.hpp | 16 ++++++++-------- 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/sycl/doc/extensions/experimental/sycl_ext_oneapi_bindless_images.asciidoc b/sycl/doc/extensions/experimental/sycl_ext_oneapi_bindless_images.asciidoc index ba4ba85bc1a84..71bc0dc031d64 100644 --- a/sycl/doc/extensions/experimental/sycl_ext_oneapi_bindless_images.asciidoc +++ b/sycl/doc/extensions/experimental/sycl_ext_oneapi_bindless_images.asciidoc @@ -1364,7 +1364,7 @@ and the array index. // Fetch an unsampled image array template DataT fetch_image_array(const unsampled_image_handle &ImageHandle, - const CoordT &Coords, const unsigned int ArrayLayer); + const CoordT &Coords, unsigned int ArrayLayer); ``` Fetching an image array follows the same restrictions on what coordinate types @@ -1390,7 +1390,7 @@ provided that type is trivially copyable. // Write to an unsampled image array template DataT write_image_array(unsampled_image_handle ImageHandle, - const CoordT &Coords, const unsigned int ArrayLayer + const CoordT &Coords, unsigned int ArrayLayer const DataT &Color); ``` @@ -1495,7 +1495,7 @@ sampling depends on the sampler attributes passed upon creation of the cubemap. template DataT fetch_cubemap(const unsampled_image_handle &ImageHandle, const int2 &Coords, - const int Face); + int Face); // Sampled cubemap read template @@ -1506,7 +1506,7 @@ DataT sample_cubemap(const sampled_image_handle &ImageHandle, template void write_cubemap(unsampled_image_handle ImageHandle, const int2 &Coords, - const int Face, + int Face, const DataT &Color); ``` diff --git a/sycl/include/sycl/ext/oneapi/bindless_images.hpp b/sycl/include/sycl/ext/oneapi/bindless_images.hpp index 51ad2e9815fd0..4a8f618a78959 100644 --- a/sycl/include/sycl/ext/oneapi/bindless_images.hpp +++ b/sycl/include/sycl/ext/oneapi/bindless_images.hpp @@ -181,7 +181,7 @@ void free_mipmap_mem(image_mem_handle handle, const sycl::queue &syclQueue); * @return Memory handle to the individual mipmap image */ __SYCL_EXPORT image_mem_handle get_mip_level_mem_handle( - const image_mem_handle mipMem, const unsigned int level, + const image_mem_handle mipMem, unsigned int level, const sycl::device &syclDevice, const sycl::context &syclContext); /** @@ -192,9 +192,9 @@ __SYCL_EXPORT image_mem_handle get_mip_level_mem_handle( * @param syclQueue The queue in which we created our memory handle * @return Memory handle to the individual mipmap image */ -__SYCL_EXPORT image_mem_handle get_mip_level_mem_handle( - const image_mem_handle mipMem, const unsigned int level, - const sycl::queue &syclQueue); +__SYCL_EXPORT image_mem_handle +get_mip_level_mem_handle(const image_mem_handle mipMem, unsigned int level, + const sycl::queue &syclQueue); /** * @brief Import external memory taking an external memory handle (the type @@ -1299,7 +1299,7 @@ template DataT fetch_image_array(const unsampled_image_handle &imageHandle [[maybe_unused]], const CoordT &coords [[maybe_unused]], - const int arrayLayer [[maybe_unused]]) { + int arrayLayer [[maybe_unused]]) { detail::assert_unsampled_coords(); constexpr size_t coordSize = detail::coord_size(); static_assert(coordSize == 1 || coordSize == 2, @@ -1347,7 +1347,7 @@ DataT fetch_image_array(const unsampled_image_handle &imageHandle */ template DataT fetch_cubemap(const unsampled_image_handle &imageHandle, - const int2 &coords, const unsigned int face) { + const int2 &coords, unsigned int face) { return fetch_image_array(imageHandle, coords, face); } @@ -1442,7 +1442,7 @@ void write_image(unsampled_image_handle imageHandle [[maybe_unused]], template void write_image_array(unsampled_image_handle imageHandle [[maybe_unused]], const CoordT &coords [[maybe_unused]], - const int arrayLayer [[maybe_unused]], + int arrayLayer [[maybe_unused]], const DataT &color [[maybe_unused]]) { detail::assert_unsampled_coords(); constexpr size_t coordSize = detail::coord_size(); @@ -1482,7 +1482,7 @@ void write_image_array(unsampled_image_handle imageHandle [[maybe_unused]], */ template void write_cubemap(unsampled_image_handle imageHandle, const sycl::int2 &coords, - const int face, const DataT &color) { + int face, const DataT &color) { return write_image_array(imageHandle, coords, face, color); }